PDFBOX-5660: simplify code, as suggested by Valery Bokov; closes #216

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1927848 13f79535-47bb-0310-9956-ffa450edef68

Author: THausherr

pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java

@@ -504,9 +504,10 @@ else if (defaultOverlayPage != null)
                 // Note that this segment is only the second best solution to the problem. The best
                 // would be to make appropriate transforms in calculateAffineTransform()                
                 PDPage page = inputPDFDocument.getPage(pageNumber - 1);
-                if (page.getRotation() != 0)
+                int rotation = page.getRotation();
+                if (rotation != 0)
                 {
-                    return createAdjustedLayoutPage(page);
+                    return createAdjustedLayoutPage(rotation);
                 }
             }
         }
@@ -518,16 +519,16 @@ else if (useAllOverlayPages)
         return layoutPage;
     }
 
-    private LayoutPage createAdjustedLayoutPage(PDPage page) throws IOException
+    private LayoutPage createAdjustedLayoutPage(int rotation) throws IOException
     {
-        LayoutPage rotatedLayoutPage = rotatedDefaultOverlayPagesMap.get(page.getRotation());
+        LayoutPage rotatedLayoutPage = rotatedDefaultOverlayPagesMap.get(rotation);
         if (rotatedLayoutPage == null)
         {
             // createLayoutPage must be called because we can't reuse the COSStream
             rotatedLayoutPage = createLayoutPage(defaultOverlayDocument.getPage(0));
-            int newRotation = (rotatedLayoutPage.overlayRotation - page.getRotation() + 360) % 360;
+            int newRotation = (rotatedLayoutPage.overlayRotation - rotation + 360) % 360;
             rotatedLayoutPage.overlayRotation = newRotation;
-            rotatedDefaultOverlayPagesMap.put(page.getRotation(), rotatedLayoutPage);
+            rotatedDefaultOverlayPagesMap.put(rotation, rotatedLayoutPage);
         }
         return rotatedLayoutPage;
     }