PDFBOX-5996: Set size for ByteArrayOutputStreams, as suggested by Axel Howind

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1925301 13f79535-47bb-0310-9956-ffa450edef68

Author: THausherr

fontbox/src/main/java/org/apache/fontbox/ttf/TTFSubsetter.java

@@ -235,7 +235,7 @@ private void writeTableBody(OutputStream os, byte[] bytes) throws IOException
 
     private byte[] buildHeadTable() throws IOException
     {
-        ByteArrayOutputStream bos = new ByteArrayOutputStream();
+        ByteArrayOutputStream bos = new ByteArrayOutputStream(54);
         DataOutputStream out = new DataOutputStream(bos);
 
         HeaderTable h = ttf.getHeader();
@@ -264,7 +264,7 @@ private byte[] buildHeadTable() throws IOException
 
     private byte[] buildHheaTable() throws IOException
     {
-        ByteArrayOutputStream bos = new ByteArrayOutputStream();
+        ByteArrayOutputStream bos = new ByteArrayOutputStream(36);
         DataOutputStream out = new DataOutputStream(bos);
 
         HorizontalHeaderTable h = ttf.getHorizontalHeader();
@@ -308,7 +308,7 @@ private boolean shouldCopyNameRecord(NameRecord nr)
 
     private byte[] buildNameTable() throws IOException
     {
-        ByteArrayOutputStream bos = new ByteArrayOutputStream();
+        ByteArrayOutputStream bos = new ByteArrayOutputStream(512);
         DataOutputStream out = new DataOutputStream(bos);
 
         NamingTable name = ttf.getNaming();
@@ -393,7 +393,7 @@ else if (encoding == 1) // ISO 10646=
 
     private byte[] buildMaxpTable() throws IOException
     {
-        ByteArrayOutputStream bos = new ByteArrayOutputStream();
+        ByteArrayOutputStream bos = new ByteArrayOutputStream(32);
         DataOutputStream out = new DataOutputStream(bos);
 
         MaximumProfileTable p = ttf.getMaximumProfile();
@@ -428,7 +428,7 @@ private byte[] buildOS2Table() throws IOException
             return null;
         }
 
-        ByteArrayOutputStream bos = new ByteArrayOutputStream();
+        ByteArrayOutputStream bos = new ByteArrayOutputStream(78);
         DataOutputStream out = new DataOutputStream(bos);
 
         writeUint16(out, os2.getVersion());
@@ -476,7 +476,7 @@ private byte[] buildOS2Table() throws IOException
     // never returns null
     private byte[] buildLocaTable(long[] newOffsets) throws IOException
     {
-        ByteArrayOutputStream bos = new ByteArrayOutputStream();
+        ByteArrayOutputStream bos = new ByteArrayOutputStream(newOffsets.length * 4);
         DataOutputStream out = new DataOutputStream(bos);
 
         for (long offset : newOffsets)
@@ -598,7 +598,7 @@ else if ((flags & 1 << 3) != 0)
     // never returns null
     private byte[] buildGlyfTable(long[] newOffsets) throws IOException
     {
-        ByteArrayOutputStream bos = new ByteArrayOutputStream();
+        ByteArrayOutputStream bos = new ByteArrayOutputStream(512);
 
         GlyphTable g = ttf.getGlyph();
         long[] offsets = ttf.getIndexToLocation().getOffsets();
@@ -749,7 +749,7 @@ private byte[] buildCmapTable() throws IOException
             return null;
         }
 
-        ByteArrayOutputStream bos = new ByteArrayOutputStream();
+        ByteArrayOutputStream bos = new ByteArrayOutputStream(64);
         DataOutputStream out = new DataOutputStream(bos);
 
         // cmap header
@@ -869,7 +869,7 @@ private byte[] buildPostTable() throws IOException
             return null;
         }
 
-        ByteArrayOutputStream bos = new ByteArrayOutputStream();
+        ByteArrayOutputStream bos = new ByteArrayOutputStream(64);
         DataOutputStream out = new DataOutputStream(bos);
 
         writeFixed(out, 2.0); // version

pdfbox/src/main/java/org/apache/pdfbox/cos/COSString.java

@@ -135,7 +135,6 @@ public COSString(String text, boolean forceHex)
      */
     public static COSString parseHex(String hex) throws IOException
     {
-        ByteArrayOutputStream bytes = new ByteArrayOutputStream();
         StringBuilder hexBuffer = new StringBuilder(hex.trim());
 
         // if odd number then the last hex digit is assumed to be 0
@@ -145,6 +144,7 @@ public static COSString parseHex(String hex) throws IOException
         }
 
         int length = hexBuffer.length();
+        ByteArrayOutputStream bytes = new ByteArrayOutputStream((length + 1) / 2);
         for (int i = 0; i < length; i += 2)
         {
             try

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDFont.java

@@ -328,7 +328,7 @@ public float getWidth(int code) throws IOException
      */
     public final byte[] encode(String text) throws IOException
     {
-        ByteArrayOutputStream out = new ByteArrayOutputStream();
+        ByteArrayOutputStream out = new ByteArrayOutputStream(Math.max(32, text.length()));
         int offset = 0;
         while (offset < text.length())
         {

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/image/CCITTFactory.java

@@ -68,7 +68,7 @@ public static PDImageXObject createFromImage(PDDocument document, BufferedImage
         int height = image.getHeight();
         int width = image.getWidth();
 
-        ByteArrayOutputStream bos = new ByteArrayOutputStream();
+        ByteArrayOutputStream bos = new ByteArrayOutputStream(Math.max(32, (width + 1) * height));
         try (MemoryCacheImageOutputStream mcios = new MemoryCacheImageOutputStream(bos))
         {
             for (int y = 0; y < height; ++y)