Skip to content

Commit ea9724b

Browse files
committed
PDFBOX-5660: Sonar fix
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1924872 13f79535-47bb-0310-9956-ffa450edef68
1 parent 4e54c0d commit ea9724b

File tree

6 files changed

+12
-11
lines changed

6 files changed

+12
-11
lines changed

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/pattern/PDAbstractPattern.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public static PDAbstractPattern create(COSDictionary dictionary, ResourceCache r
6868
/**
6969
* Creates a new Pattern dictionary.
7070
*/
71-
public PDAbstractPattern()
71+
protected PDAbstractPattern()
7272
{
7373
patternDictionary = new COSDictionary();
7474
patternDictionary.setName(COSName.TYPE, COSName.PATTERN.getName());
@@ -78,7 +78,7 @@ public PDAbstractPattern()
7878
* Creates a new Pattern dictionary from the given COS dictionary.
7979
* @param dictionary The COSDictionary for this pattern.
8080
*/
81-
public PDAbstractPattern(COSDictionary dictionary)
81+
protected PDAbstractPattern(COSDictionary dictionary)
8282
{
8383
patternDictionary = dictionary;
8484
}

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDAbstractAppearanceHandler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,12 @@ public abstract class PDAbstractAppearanceHandler implements PDAppearanceHandler
6868
*/
6969
protected static final Set<String> ANGLED_STYLES = createAngledStyles();
7070

71-
public PDAbstractAppearanceHandler(PDAnnotation annotation)
71+
protected PDAbstractAppearanceHandler(PDAnnotation annotation)
7272
{
7373
this(annotation, null);
7474
}
7575

76-
public PDAbstractAppearanceHandler(PDAnnotation annotation, PDDocument document)
76+
protected PDAbstractAppearanceHandler(PDAnnotation annotation, PDDocument document)
7777
{
7878
this.annotation = annotation;
7979
this.document = document;

xmpbox/src/main/java/org/apache/xmpbox/type/AbstractComplexProperty.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public abstract class AbstractComplexProperty extends AbstractField
3434

3535
private final Map<String, String> namespaceToPrefix;
3636

37-
public AbstractComplexProperty(XMPMetadata metadata, String propertyName)
37+
protected AbstractComplexProperty(XMPMetadata metadata, String propertyName)
3838
{
3939
super(metadata, propertyName);
4040
container = new ComplexPropertyContainer();

xmpbox/src/main/java/org/apache/xmpbox/type/AbstractField.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public abstract class AbstractField
5151
* @param propertyName
5252
* the local name to set for this field
5353
*/
54-
public AbstractField(XMPMetadata metadata, String propertyName)
54+
protected AbstractField(XMPMetadata metadata, String propertyName)
5555
{
5656
this.metadata = metadata;
5757
this.propertyName = propertyName;

xmpbox/src/main/java/org/apache/xmpbox/type/AbstractSimpleProperty.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,15 +52,14 @@ public abstract class AbstractSimpleProperty extends AbstractField
5252
* @param value
5353
* the value to give
5454
*/
55-
public AbstractSimpleProperty(XMPMetadata metadata, String namespaceURI, String prefix, String propertyName,
55+
protected AbstractSimpleProperty(XMPMetadata metadata, String namespaceURI, String prefix, String propertyName,
5656
Object value)
5757
{
5858
super(metadata, propertyName);
5959
setValue(value);
6060
this.namespace = namespaceURI;
6161
this.prefix = prefix;
6262
this.rawValue = value;
63-
6463
}
6564

6665
/**

xmpbox/src/main/java/org/apache/xmpbox/type/AbstractStructuredType.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,12 @@ public abstract class AbstractStructuredType extends AbstractComplexProperty
3636

3737
private String prefix;
3838

39-
public AbstractStructuredType(XMPMetadata metadata)
39+
protected AbstractStructuredType(XMPMetadata metadata)
4040
{
4141
this(metadata, null, null, null);
4242
}
4343

44-
public AbstractStructuredType(XMPMetadata metadata, String namespaceURI)
44+
protected AbstractStructuredType(XMPMetadata metadata, String namespaceURI)
4545
{
4646
this(metadata, namespaceURI, null, null);
4747
StructuredType st = this.getClass().getAnnotation(StructuredType.class);
@@ -58,7 +58,7 @@ public AbstractStructuredType(XMPMetadata metadata, String namespaceURI)
5858
this.prefix = this.preferedPrefix;
5959
}
6060

61-
public AbstractStructuredType(XMPMetadata metadata, String namespaceURI, String fieldPrefix, String propertyName)
61+
protected AbstractStructuredType(XMPMetadata metadata, String namespaceURI, String fieldPrefix, String propertyName)
6262
{
6363
super(metadata, propertyName);
6464
StructuredType st = this.getClass().getAnnotation(StructuredType.class);
@@ -87,6 +87,7 @@ public AbstractStructuredType(XMPMetadata metadata, String namespaceURI, String
8787
*
8888
* @return the namespace URI
8989
*/
90+
@Override
9091
public final String getNamespace()
9192
{
9293
return namespace;
@@ -102,6 +103,7 @@ public final void setNamespace(String ns)
102103
*
103104
* @return the prefix specified
104105
*/
106+
@Override
105107
public final String getPrefix()
106108
{
107109
return prefix;

0 commit comments

Comments
 (0)