PDFBOX-5660: avoid potential ClassCastException

THausherr · THausherr · commit f0a6cb3293b4 · 2025-11-29T09:56:35.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1930094 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/xmpbox/src/main/java/org/apache/xmpbox/type/AbstractStructuredType.java b/xmpbox/src/main/java/org/apache/xmpbox/type/AbstractStructuredType.java
@@ -111,15 +111,12 @@ protected void addSimpleProperty(String propertyName, Object value)
 
     protected String getPropertyValueAsString(String fieldName)
     {
-        AbstractSimpleProperty absProp = (AbstractSimpleProperty) getProperty(fieldName);
-        if (absProp == null)
+        AbstractField absProp = getProperty(fieldName);
+        if (absProp instanceof AbstractSimpleProperty)
         {
-            return null;
-        }
-        else
-        {
-            return absProp.getStringValue();
+            return ((AbstractSimpleProperty) absProp).getStringValue();
         }
+        return null;
     }
 
     protected Calendar getDatePropertyAsCalendar(String fieldName)

Original file line number	Diff line number	Diff line change
`@@ -111,15 +111,12 @@ protected void addSimpleProperty(String propertyName, Object value)`
`111`	`111`
`112`	`112`	`protected String getPropertyValueAsString(String fieldName)`
`113`	`113`	`{`
`114`		`- AbstractSimpleProperty absProp = (AbstractSimpleProperty) getProperty(fieldName);`
`115`		`- if (absProp == null)`
	`114`	`+ AbstractField absProp = getProperty(fieldName);`
	`115`	`+ if (absProp instanceof AbstractSimpleProperty)`
`116`	`116`	`{`
`117`		`- return null;`
`118`		`- }`
`119`		`- else`
`120`		`- {`
`121`		`- return absProp.getStringValue();`
	`117`	`+ return ((AbstractSimpleProperty) absProp).getStringValue();`
`122`	`118`	`}`
	`119`	`+ return null;`
`123`	`120`	`}`
`124`	`121`
`125`	`122`	`protected Calendar getDatePropertyAsCalendar(String fieldName)`