PDFBOX-5660: improve exception message, refactor

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1930142 13f79535-47bb-0310-9956-ffa450edef68

Author: THausherr

xmpbox/src/main/java/org/apache/xmpbox/xml/DomXmpParser.java

@@ -627,11 +627,13 @@ private AbstractStructuredType parseLiDescription(XMPMetadata xmp, QName descrip
         // Instantiate abstract structured type with hint from first element
         Element firstLiDescriptionElementChild = liDescriptionElementChildren.get(0);
         nsFinder.push(firstLiDescriptionElementChild);
-        PropertyType ctype = checkPropertyDefinition(xmp, DomHelper.getQName(firstLiDescriptionElementChild));
+        QName qName = DomHelper.getQName(firstLiDescriptionElementChild);
+        PropertyType ctype = checkPropertyDefinition(xmp, qName);
         if (ctype == null)
         {
-            throw new XmpParsingException(ErrorType.NoType, "ctype is null, first: " + firstLiDescriptionElementChild + 
-                    ", DomHelper.getQName(first): " + DomHelper.getQName(firstLiDescriptionElementChild));
+            // PDFBOX-5649
+            throw new XmpParsingException(ErrorType.NoType,
+                    "Property '" + qName.getLocalPart() + "' not defined in " + qName.getNamespaceURI());
         }
         Types tt = ctype.type();
         AbstractStructuredType ast = instanciateStructured(tm, tt, descriptor.getLocalPart(), firstLiDescriptionElementChild.getNamespaceURI());