PDFBOX-5660: refactor, as suggested by Valery Bokov; closes #227

THausherr · THausherr · commit f383393a4d9d · 2025-08-27T19:33:05.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1928055 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/pdfbox/src/main/java/org/apache/pdfbox/multipdf/PDFCloneUtility.java b/pdfbox/src/main/java/org/apache/pdfbox/multipdf/PDFCloneUtility.java
@@ -210,9 +210,10 @@ private void cloneMergeCOSBase(final COSBase source, final COSBase target) throw
         if (sourceBase instanceof COSArray && targetBase instanceof COSArray)
         {
             COSArray array = (COSArray) sourceBase;
+            COSArray targetBaseArray = (COSArray) targetBase;
             for (int i = 0; i < array.size(); i++)
             {
-                ((COSArray) targetBase).add(cloneForNewDocument(array.get(i)));
+                targetBaseArray.add(cloneForNewDocument(array.get(i)));
             }
         }
         else if (sourceBase instanceof COSDictionary && targetBase instanceof COSDictionary)

Original file line number	Diff line number	Diff line change
`@@ -210,9 +210,10 @@ private void cloneMergeCOSBase(final COSBase source, final COSBase target) throw`
`210`	`210`	`if (sourceBase instanceof COSArray && targetBase instanceof COSArray)`
`211`	`211`	`{`
`212`	`212`	`COSArray array = (COSArray) sourceBase;`
	`213`	`+ COSArray targetBaseArray = (COSArray) targetBase;`
`213`	`214`	`for (int i = 0; i < array.size(); i++)`
`214`	`215`	`{`
`215`		`- ((COSArray) targetBase).add(cloneForNewDocument(array.get(i)));`
	`216`	`+ targetBaseArray.add(cloneForNewDocument(array.get(i)));`
`216`	`217`	`}`
`217`	`218`	`}`
`218`	`219`	`else if (sourceBase instanceof COSDictionary && targetBase instanceof COSDictionary)`