Skip to content

Commit f95e05e

Browse files
committed
PDFBOX-5660: optimize, as suggested by Valery Bokov; DRY refactoring; closes #330
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1929759 13f79535-47bb-0310-9956-ffa450edef68
1 parent 124982c commit f95e05e

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BruteForceParser.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import java.util.HashMap;
2222
import java.util.List;
2323
import java.util.Map;
24+
import java.util.Set;
2425
import java.util.Map.Entry;
2526
import java.util.stream.Collectors;
2627

@@ -307,14 +308,15 @@ protected void bfSearchForObjStreams(Map<COSObjectKey, Long> xrefTable) throws I
307308

308309
Map<Long, COSObjectKey> bfSearchForObjStreamOffsets = bfSearchForObjStreamOffsets();
309310
Map<COSObjectKey, Long> bfCOSObjectOffsets = getBFCOSObjectOffsets();
311+
Set<Entry<Long, COSObjectKey>> entries = bfSearchForObjStreamOffsets.entrySet();
310312
// log warning about skipped stream
311-
bfSearchForObjStreamOffsets.entrySet().stream() //
313+
entries.stream() //
312314
.filter(o -> bfCOSObjectOffsets.get(o.getValue()) == null) //
313315
.forEach(o -> LOG.warn("Skipped incomplete object stream:{} at {}", o.getValue(),
314316
o.getKey()));
315317

316318
// collect all stream offsets
317-
List<Long> objStreamOffsets = bfSearchForObjStreamOffsets.entrySet().stream() //
319+
List<Long> objStreamOffsets = entries.stream() //
318320
.filter(o -> bfCOSObjectOffsets.get(o.getValue()) != null) //
319321
.filter(o -> o.getKey().equals(bfCOSObjectOffsets.get(o.getValue()))) //
320322
.map(Map.Entry::getKey) //

0 commit comments

Comments
 (0)