rework test

pjfanning · pjfanning · commit 7c34c67678f0 · 2025-01-02T18:04:18.000+01:00
diff --git a/remote/src/test/scala/org/apache/pekko/remote/artery/HarmlessQuarantineSpec.scala b/remote/src/test/scala/org/apache/pekko/remote/artery/HarmlessQuarantineSpec.scala
@@ -77,8 +77,8 @@ class HarmlessQuarantineSpec extends ArteryMultiNodeSpec("""
         association.associationState.isQuarantined(remoteUid) shouldBe true
         association.associationState.quarantinedButHarmless(remoteUid) shouldBe false
 
+        remoteEcho.tell("ping", localEchoRef) // trigger sending message from remote to local, which will trigger local to wrongfully notify remote that it is quarantined
         eventually {
-          remoteEcho.tell("ping", localEchoRef) // trigger sending message from remote to local, which will trigger local to wrongfully notify remote that it is quarantined
           expectMsgType[ThisActorSystemQuarantinedEvent] // this is what remote emits when it learns it is quarantined by local
         }
     }
@@ -104,8 +104,8 @@ class HarmlessQuarantineSpec extends ArteryMultiNodeSpec("""
         association.associationState.isQuarantined(remoteUid) shouldBe true
         association.associationState.quarantinedButHarmless(remoteUid) shouldBe true
 
+        remoteEcho.tell("ping", localEchoRef) // trigger sending message from remote to local, which will trigger local to wrongfully notify remote that it is quarantined
         eventually {
-          remoteEcho.tell("ping", localEchoRef) // trigger sending message from remote to local, which will trigger local to wrongfully notify remote that it is quarantined
           expectNoMessage()
         }
     }
diff --git a/remote/src/test/scala/org/apache/pekko/remote/artery/OutboundIdleShutdownSpec.scala b/remote/src/test/scala/org/apache/pekko/remote/artery/OutboundIdleShutdownSpec.scala
@@ -173,8 +173,8 @@ class OutboundIdleShutdownSpec extends ArteryMultiNodeSpec("""
         association.associationState.isQuarantined(remoteUid) shouldBe true
         association.associationState.quarantinedButHarmless(remoteUid) shouldBe false
 
+        remoteEcho.tell("ping", localEchoRef) // trigger sending message from remote to local, which will trigger local to wrongfully notify remote that it is quarantined
         eventually {
-          remoteEcho.tell("ping", localEchoRef) // trigger sending message from remote to local, which will trigger local to wrongfully notify remote that it is quarantined
           expectMsgType[ThisActorSystemQuarantinedEvent] // this is what remote emits when it learns it is quarantined by local
         }
     }
@@ -200,8 +200,8 @@ class OutboundIdleShutdownSpec extends ArteryMultiNodeSpec("""
         association.associationState.isQuarantined(remoteUid) shouldBe true
         association.associationState.quarantinedButHarmless(remoteUid) shouldBe true
 
+        remoteEcho.tell("ping", localEchoRef) // trigger sending message from remote to local, which will trigger local to wrongfully notify remote that it is quarantined
         eventually {
-          remoteEcho.tell("ping", localEchoRef) // trigger sending message from remote to local, which will trigger local to wrongfully notify remote that it is quarantined
           expectMsgType[ThisActorSystemQuarantinedEvent] // this is what remote emits when it learns it is quarantined by local
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -77,8 +77,8 @@ class HarmlessQuarantineSpec extends ArteryMultiNodeSpec("""`
`77`	`77`	`association.associationState.isQuarantined(remoteUid) shouldBe true`
`78`	`78`	`association.associationState.quarantinedButHarmless(remoteUid) shouldBe false`
`79`	`79`
	`80`	`+ remoteEcho.tell("ping", localEchoRef) // trigger sending message from remote to local, which will trigger local to wrongfully notify remote that it is quarantined`
`80`	`81`	`eventually {`
`81`		`- remoteEcho.tell("ping", localEchoRef) // trigger sending message from remote to local, which will trigger local to wrongfully notify remote that it is quarantined`
`82`	`82`	`expectMsgType[ThisActorSystemQuarantinedEvent] // this is what remote emits when it learns it is quarantined by local`
`83`	`83`	`}`
`84`	`84`	`}`
`@@ -104,8 +104,8 @@ class HarmlessQuarantineSpec extends ArteryMultiNodeSpec("""`
`104`	`104`	`association.associationState.isQuarantined(remoteUid) shouldBe true`
`105`	`105`	`association.associationState.quarantinedButHarmless(remoteUid) shouldBe true`
`106`	`106`
	`107`	`+ remoteEcho.tell("ping", localEchoRef) // trigger sending message from remote to local, which will trigger local to wrongfully notify remote that it is quarantined`
`107`	`108`	`eventually {`
`108`		`- remoteEcho.tell("ping", localEchoRef) // trigger sending message from remote to local, which will trigger local to wrongfully notify remote that it is quarantined`
`109`	`109`	`expectNoMessage()`
`110`	`110`	`}`
`111`	`111`	`}`
Original file line number	Diff line number	Diff line change
`@@ -173,8 +173,8 @@ class OutboundIdleShutdownSpec extends ArteryMultiNodeSpec("""`
`173`	`173`	`association.associationState.isQuarantined(remoteUid) shouldBe true`
`174`	`174`	`association.associationState.quarantinedButHarmless(remoteUid) shouldBe false`
`175`	`175`
	`176`	`+ remoteEcho.tell("ping", localEchoRef) // trigger sending message from remote to local, which will trigger local to wrongfully notify remote that it is quarantined`
`176`	`177`	`eventually {`
`177`		`- remoteEcho.tell("ping", localEchoRef) // trigger sending message from remote to local, which will trigger local to wrongfully notify remote that it is quarantined`
`178`	`178`	`expectMsgType[ThisActorSystemQuarantinedEvent] // this is what remote emits when it learns it is quarantined by local`
`179`	`179`	`}`
`180`	`180`	`}`
`@@ -200,8 +200,8 @@ class OutboundIdleShutdownSpec extends ArteryMultiNodeSpec("""`
`200`	`200`	`association.associationState.isQuarantined(remoteUid) shouldBe true`
`201`	`201`	`association.associationState.quarantinedButHarmless(remoteUid) shouldBe true`
`202`	`202`
	`203`	`+ remoteEcho.tell("ping", localEchoRef) // trigger sending message from remote to local, which will trigger local to wrongfully notify remote that it is quarantined`
`203`	`204`	`eventually {`
`204`		`- remoteEcho.tell("ping", localEchoRef) // trigger sending message from remote to local, which will trigger local to wrongfully notify remote that it is quarantined`
`205`	`205`	`expectMsgType[ThisActorSystemQuarantinedEvent] // this is what remote emits when it learns it is quarantined by local`
`206`	`206`	`}`
`207`	`207`	`}`