Skip to content

Commit abe9c6e

Browse files
authored
chore: test Scala 3 with validatePullRequest (#2544)
The Scala 3 build+test job takes almost an hour because it runs all tests, while the Scala 2 build+test job is sometimes much faster because it runs with `validatePullRequest` which selects which tests to run based on the files that were changed. I don't think we've regularly seen situations where a failure was missed by `validatePullRequest` and caught by the Scala 3 test, so it might be nice to run those with `validatePullRequest` as well.
1 parent 22e985e commit abe9c6e

File tree

2 files changed

+5
-80
lines changed

2 files changed

+5
-80
lines changed

.github/workflows/build-test-prValidation.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,9 @@ jobs:
5757
runs-on: ubuntu-22.04
5858
env:
5959
DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
60+
strategy:
61+
matrix:
62+
scalaVersion: ["2.13.x", "3.3.x"]
6063
steps:
6164
- name: Checkout
6265
uses: actions/[email protected]
@@ -94,7 +97,7 @@ jobs:
9497
-Dpekko.test.multi-node=false \
9598
-Dsbt.log.noformat=false \
9699
-Dpekko.log.timestamps=true \
97-
validateCompile
100+
"++ ${{ matrix.scalaVersion }} validateCompile"
98101
99102
- name: sbt validatePullRequest
100103
run: |-
@@ -110,7 +113,7 @@ jobs:
110113
-Dsbt.log.noformat=false \
111114
-Dpekko.log.timestamps=true \
112115
-Dio.netty.leakDetection.level=PARANOID \
113-
validatePullRequest
116+
"++ ${{ matrix.scalaVersion }} validatePullRequest"
114117
115118
pekko-classic-remoting-tests:
116119
name: Pekko Classic Remoting Tests

.github/workflows/scala3-build.yml

Lines changed: 0 additions & 78 deletions
This file was deleted.

0 commit comments

Comments
 (0)