[spi] Add Protobuf entry in RecordReaderFactory

Author: anshul98ks123

pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/FileFormat.java

@@ -19,5 +19,5 @@
 package org.apache.pinot.spi.data.readers;
 
 public enum FileFormat {
-  AVRO, GZIPPED_AVRO, CSV, JSON, PINOT, THRIFT, PARQUET, ORC, PROTO, OTHER
+  AVRO, GZIPPED_AVRO, CSV, JSON, PINOT, THRIFT, PARQUET, ORC, PROTO, OTHER, PROTOBUF
 }

pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/RecordReaderFactory.java

@@ -53,6 +53,10 @@ private RecordReaderFactory() {
       "org.apache.pinot.plugin.inputformat.parquet.ParquetRecordReader";
   static final String DEFAULT_PARQUET_RECORD_READER_CONFIG_CLASS =
       "org.apache.pinot.plugin.inputformat.parquet.ParquetRecordReaderConfig";
+  static final String DEFAULT_PROTO_RECORD_READER_CLASS =
+      "org.apache.pinot.plugin.inputformat.protobuf.ProtoBufRecordReader";
+  static final String DEFAULT_PROTO_RECORD_READER_CONFIG_CLASS =
+      "org.apache.pinot.plugin.inputformat.protobuf.ProtoBufRecordReaderConfig";
 
   public static void register(String fileFormat, String recordReaderClassName, String recordReaderConfigClassName) {
     DEFAULT_RECORD_READER_CLASS_MAP.put(fileFormat.toUpperCase(), recordReaderClassName);
@@ -71,6 +75,7 @@ public static void register(FileFormat fileFormat, String recordReaderClassName,
     register(FileFormat.THRIFT, DEFAULT_THRIFT_RECORD_READER_CLASS, DEFAULT_THRIFT_RECORD_READER_CONFIG_CLASS);
     register(FileFormat.ORC, DEFAULT_ORC_RECORD_READER_CLASS, null);
     register(FileFormat.PARQUET, DEFAULT_PARQUET_RECORD_READER_CLASS, DEFAULT_PARQUET_RECORD_READER_CONFIG_CLASS);
+    register(FileFormat.PROTOBUF, DEFAULT_PROTO_RECORD_READER_CLASS, DEFAULT_PROTO_RECORD_READER_CONFIG_CLASS);
   }
 
   /**

pinot-spi/src/test/java/org/apache/pinot/spi/data/readers/RecordReaderFactoryTest.java

@@ -36,6 +36,7 @@ public void testGetRecordReaderClassName() {
     assertEquals(getRecordReaderClassName("thrift"), DEFAULT_THRIFT_RECORD_READER_CLASS);
     assertEquals(getRecordReaderClassName("orc"), DEFAULT_ORC_RECORD_READER_CLASS);
     assertEquals(getRecordReaderClassName("parquet"), DEFAULT_PARQUET_RECORD_READER_CLASS);
+    assertEquals(getRecordReaderClassName("protobuf"), DEFAULT_PROTO_RECORD_READER_CLASS);
   }
 
   @Test
@@ -47,5 +48,6 @@ public void testGetRecordReaderConfigClassName() {
     assertEquals(getRecordReaderConfigClassName("thrift"), DEFAULT_THRIFT_RECORD_READER_CONFIG_CLASS);
     assertNull(getRecordReaderConfigClassName("orc"));
     assertEquals(getRecordReaderConfigClassName("parquet"), DEFAULT_PARQUET_RECORD_READER_CONFIG_CLASS);
+    assertEquals(getRecordReaderConfigClassName("protobuf"), DEFAULT_PROTO_RECORD_READER_CONFIG_CLASS);
   }
-}
+}

pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/ImportDataCommand.java

@@ -380,6 +380,7 @@ private String getRecordReaderConfigClass(FileFormat format) {
       case CSV:
         return "org.apache.pinot.plugin.inputformat.csv.CSVRecordReaderConfig";
       case PROTO:
+      case PROTOBUF:
         return "org.apache.pinot.plugin.inputformat.protobuf.ProtoBufRecordReaderConfig";
       case THRIFT:
         return "org.apache.pinot.plugin.inputformat.thrift.ThriftRecordReaderConfig";
@@ -406,6 +407,7 @@ private String getRecordReaderClass(FileFormat format) {
       case PARQUET:
         return "org.apache.pinot.plugin.inputformat.parquet.ParquetRecordReader";
       case PROTO:
+      case PROTOBUF:
         return "org.apache.pinot.plugin.inputformat.protobuf.ProtoBufRecordReader";
       case THRIFT:
         return "org.apache.pinot.plugin.inputformat.thrift.ThriftRecordReader";