switch order (#13)

Author: mansehajsingh

polaris-synchronizer/api/src/main/java/org/apache/polaris/tools/sync/polaris/PolarisSynchronizer.java

@@ -630,8 +630,6 @@ public void syncCatalogs() {
     }
 
     for (Catalog catalog : catalogSyncPlan.entitiesToSyncChildren()) {
-      syncCatalogRoles(catalog.getName());
-
       IcebergCatalogService sourceIcebergCatalogService;
 
       try {
@@ -666,6 +664,11 @@ public void syncCatalogs() {
 
       syncNamespaces(
           catalog.getName(), Namespace.empty(), sourceIcebergCatalogService, targetIcebergCatalogService);
+
+      // NOTE: Grants are synced on a per catalog role basis, so we need to ensure that catalog roles
+      // are only synced AFTER Iceberg catalog entities, because they may depend on the Iceberg catalog
+      // entities already existing
+      syncCatalogRoles(catalog.getName());
     }
   }