Skip to content

Commit efc68e8

Browse files
authored
Use PolarisTaskConstants (#2346)
1 parent a8ca16b commit efc68e8

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

polaris-core/src/main/java/org/apache/polaris/core/persistence/AtomicOperationMetaStoreManager.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1226,7 +1226,8 @@ private void revokeGrantRecord(
12261226
properties.put(
12271227
PolarisTaskConstants.TASK_TYPE,
12281228
String.valueOf(AsyncTaskType.ENTITY_CLEANUP_SCHEDULER.typeCode()));
1229-
properties.put("data", PolarisObjectMapperUtil.serialize(refreshEntityToDrop));
1229+
properties.put(
1230+
PolarisTaskConstants.TASK_DATA, PolarisObjectMapperUtil.serialize(refreshEntityToDrop));
12301231
PolarisBaseEntity.Builder taskEntityBuilder =
12311232
new PolarisBaseEntity.Builder()
12321233
.properties(PolarisObjectMapperUtil.serializeProperties(properties))

polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/TransactionalMetaStoreManagerImpl.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1428,7 +1428,8 @@ private void bootstrapPolarisService(
14281428
properties.put(
14291429
PolarisTaskConstants.TASK_TYPE,
14301430
String.valueOf(AsyncTaskType.ENTITY_CLEANUP_SCHEDULER.typeCode()));
1431-
properties.put("data", PolarisObjectMapperUtil.serialize(refreshEntityToDrop));
1431+
properties.put(
1432+
PolarisTaskConstants.TASK_DATA, PolarisObjectMapperUtil.serialize(refreshEntityToDrop));
14321433
PolarisBaseEntity.Builder taskEntityBuilder =
14331434
new PolarisBaseEntity.Builder()
14341435
.id(ms.generateNewIdInCurrentTxn(callCtx))

polaris-core/src/testFixtures/java/org/apache/polaris/core/persistence/BasePolarisMetaStoreManagerTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
import org.apache.polaris.core.entity.PolarisEntity;
4242
import org.apache.polaris.core.entity.PolarisEntitySubType;
4343
import org.apache.polaris.core.entity.PolarisEntityType;
44+
import org.apache.polaris.core.entity.PolarisTaskConstants;
4445
import org.apache.polaris.core.entity.TaskEntity;
4546
import org.apache.polaris.core.persistence.pagination.PageToken;
4647
import org.assertj.core.api.Assertions;
@@ -293,8 +294,8 @@ protected void testLoadTasks() {
293294
.extracting(
294295
e -> PolarisObjectMapperUtil.deserializeProperties(e.getProperties()))
295296
.asInstanceOf(InstanceOfAssertFactories.map(String.class, String.class))
296-
.containsEntry("lastAttemptExecutorId", executorId)
297-
.containsEntry("attemptCount", "1"));
297+
.containsEntry(PolarisTaskConstants.LAST_ATTEMPT_EXECUTOR_ID, executorId)
298+
.containsEntry(PolarisTaskConstants.ATTEMPT_COUNT, "1"));
298299
Set<String> firstTasks =
299300
taskList.stream().map(PolarisBaseEntity::getName).collect(Collectors.toSet());
300301

0 commit comments

Comments
 (0)