Skip to content

Commit 0beeb4f

Browse files
committed
Fix NPE in BasicEndToEndTest.testEncryptionFailure
1 parent 8ad42f3 commit 0beeb4f

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

lib/ConsumerImpl.cc

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -592,11 +592,16 @@ void ConsumerImpl::messageReceived(const ClientConnectionPtr& cnx, const proto::
592592
<< metadata.has_num_messages_in_batch());
593593

594594
uint32_t numOfMessageReceived = m.impl_->metadata.num_messages_in_batch();
595-
if (this->ackGroupingTrackerPtr_->isDuplicate(m.getMessageId())) {
595+
auto ackGroupingTrackerPtr = ackGroupingTrackerPtr_;
596+
if (ackGroupingTrackerPtr == nullptr) { // The consumer is closing
597+
return;
598+
}
599+
if (ackGroupingTrackerPtr->isDuplicate(m.getMessageId())) {
596600
LOG_DEBUG(getName() << " Ignoring message as it was ACKed earlier by same consumer.");
597601
increaseAvailablePermits(cnx, numOfMessageReceived);
598602
return;
599603
}
604+
ackGroupingTrackerPtr.reset();
600605

601606
if (metadata.has_num_messages_in_batch()) {
602607
BitSet::Data words(msg.ack_set_size());

0 commit comments

Comments
 (0)