Rename method names

Author: BewareMyPower

lib/ClientImpl.cc

@@ -223,7 +223,7 @@ void ClientImpl::handleProducerCreated(Result result, ProducerImplBaseWeakPtr pr
                                        CreateProducerCallback callback, ProducerImplBasePtr producer) {
     if (result == ResultOk) {
         auto address = producer.get();
-        auto existingProducer = producers_.create(address, producer);
+        auto existingProducer = producers_.putIfAbsent(address, producer);
         if (existingProducer) {
             auto producer = existingProducer.value().lock();
             LOG_ERROR("Unexpected existing producer at the same address: "
@@ -312,7 +312,7 @@ void ClientImpl::handleReaderMetadataLookup(const Result result, const LookupDat
         auto consumer = weakConsumerPtr.lock();
         if (consumer) {
             auto address = consumer.get();
-            auto existingConsumer = consumers_.create(address, consumer);
+            auto existingConsumer = consumers_.putIfAbsent(address, consumer);
             if (existingConsumer) {
                 consumer = existingConsumer.value().lock();
                 LOG_ERROR("Unexpected existing consumer at the same address: "
@@ -513,7 +513,7 @@ void ClientImpl::handleConsumerCreated(Result result, ConsumerImplBaseWeakPtr co
                                        SubscribeCallback callback, ConsumerImplBasePtr consumer) {
     if (result == ResultOk) {
         auto address = consumer.get();
-        auto existingConsumer = consumers_.create(address, consumer);
+        auto existingConsumer = consumers_.putIfAbsent(address, consumer);
         if (existingConsumer) {
             auto consumer = existingConsumer.value().lock();
             LOG_ERROR("Unexpected existing consumer at the same address: "

lib/ConsumerImpl.cc

@@ -619,7 +619,7 @@ void ConsumerImpl::messageReceived(const ClientConnectionPtr& cnx, const proto::
             return;
         }
         if (redeliveryCount >= deadLetterPolicy_.getMaxRedeliverCount()) {
-            possibleSendToDeadLetterTopicMessages_.update(m.getMessageId(), std::vector<Message>{m});
+            possibleSendToDeadLetterTopicMessages_.put(m.getMessageId(), std::vector<Message>{m});
             if (redeliveryCount > deadLetterPolicy_.getMaxRedeliverCount()) {
                 redeliverUnacknowledgedMessages({m.getMessageId()});
                 increaseAvailablePermits(cnx);
@@ -786,7 +786,7 @@ uint32_t ConsumerImpl::receiveIndividualMessagesFromBatch(const ClientConnection
     }
 
     if (!possibleToDeadLetter.empty()) {
-        possibleSendToDeadLetterTopicMessages_.update(batchedMessage.getMessageId(), possibleToDeadLetter);
+        possibleSendToDeadLetterTopicMessages_.put(batchedMessage.getMessageId(), possibleToDeadLetter);
         if (redeliveryCount > deadLetterPolicy_.getMaxRedeliverCount()) {
             redeliverUnacknowledgedMessages({batchedMessage.getMessageId()});
         }

lib/MultiTopicsConsumerImpl.cc

@@ -260,7 +260,7 @@ void MultiTopicsConsumerImpl::subscribeTopicPartitions(int numPartitions, TopicN
         consumer->getConsumerCreatedFuture().addListener(std::bind(
             &MultiTopicsConsumerImpl::handleSingleConsumerCreated, get_shared_this_ptr(),
             std::placeholders::_1, std::placeholders::_2, partitionsNeedCreate, topicSubResultPromise));
-        consumers_.update(topicName->toString(), consumer);
+        consumers_.put(topicName->toString(), consumer);
         LOG_DEBUG("Creating Consumer for - " << topicName << " - " << consumerStr_);
         consumer->start();
 
@@ -287,7 +287,7 @@ void MultiTopicsConsumerImpl::subscribeTopicPartitions(int numPartitions, TopicN
                 &MultiTopicsConsumerImpl::handleSingleConsumerCreated, get_shared_this_ptr(),
                 std::placeholders::_1, std::placeholders::_2, partitionsNeedCreate, topicSubResultPromise));
             consumer->setPartitionIndex(i);
-            consumers_.update(topicPartitionName, consumer);
+            consumers_.put(topicPartitionName, consumer);
             LOG_DEBUG("Creating Consumer for - " << topicPartitionName << " - " << consumerStr_);
             consumer->start();
         }
@@ -1063,7 +1063,7 @@ void MultiTopicsConsumerImpl::subscribeSingleNewConsumer(
         });
     consumer->setPartitionIndex(partitionIndex);
     consumer->start();
-    consumers_.update(topicPartitionName, consumer);
+    consumers_.put(topicPartitionName, consumer);
     LOG_INFO("Add Creating Consumer for - " << topicPartitionName << " - " << consumerStr_
                                             << " consumerSize: " << consumers_.size());
 }

lib/SynchronizedHashMap.h

@@ -59,9 +59,9 @@ class SynchronizedHashMap {
         }
     }
 
-    // Create a new key-value pair if the key does not exist.
+    // Put a new key-value pair if the key does not exist.
     // Return boost::none if the key already exists or the existing value.
-    OptValue create(const K& key, const V& value) {
+    OptValue putIfAbsent(const K& key, const V& value) {
         Lock lock(mutex_);
         auto pair = data_.emplace(key, value);
         if (pair.second) {
@@ -71,8 +71,8 @@ class SynchronizedHashMap {
         }
     }
 
-    // Update the key with a new value no matter if the key exists.
-    void update(const K& key, const V& value) {
+    // Put a key-value pair no matter if the key exists.
+    void put(const K& key, const V& value) {
         Lock lock(mutex_);
         data_[key] = value;
     }

lib/TableViewImpl.cc

@@ -104,7 +104,7 @@ void TableViewImpl::handleMessage(const Message& msg) {
         if (msg.getLength() == 0) {
             data_.remove(msg.getPartitionKey());
         } else {
-            data_.update(msg.getPartitionKey(), value);
+            data_.put(msg.getPartitionKey(), value);
         }
 
         Lock lock(listenersMutex_);

tests/SynchronizedHashMapTest.cc

@@ -101,23 +101,23 @@ TEST(SynchronizedHashMapTest, testForEach) {
     ASSERT_TRUE(values.empty());
     ASSERT_EQ(result, 1);
 
-    ASSERT_EQ(m.create(1, 100), boost::none);
-    ASSERT_EQ(m.create(1, 101), boost::optional<int>(100));
+    ASSERT_EQ(m.putIfAbsent(1, 100), boost::none);
+    ASSERT_EQ(m.putIfAbsent(1, 101), boost::optional<int>(100));
     m.forEachValue([&values](int value, SharedFuture) { values.emplace_back(value); },
                    [&result] { result = 2; });
     ASSERT_EQ(values, (std::vector<int>({100})));
     ASSERT_EQ(result, 1);
 
-    m.update(1, 102);
+    m.put(1, 102);
     values.clear();
     m.forEachValue([&values](int value, SharedFuture) { values.emplace_back(value); },
                    [&result] { result = 2; });
     ASSERT_EQ(values, (std::vector<int>({102})));
     ASSERT_EQ(result, 1);
 
     values.clear();
-    ASSERT_EQ(m.create(2, 200), boost::none);
-    ASSERT_EQ(m.create(2, 201), boost::optional<int>(200));
+    ASSERT_EQ(m.putIfAbsent(2, 200), boost::none);
+    ASSERT_EQ(m.putIfAbsent(2, 201), boost::optional<int>(200));
     m.forEachValue([&values](int value, SharedFuture) { values.emplace_back(value); },
                    [&result] { result = 2; });
     std::sort(values.begin(), values.end());

tests/extensibleLM/ExtensibleLoadManagerTest.cc

@@ -116,7 +116,7 @@ TEST(ExtensibleLoadManagerTest, testPubSubWhileUnloading) {
             ASSERT_EQ(sendResult, ResultOk);
             ASSERT_TRUE(elapsed < maxWaitTimeMs);
 
-            producedMsgs.update(i, i);
+            producedMsgs.put(i, i);
             i++;
         }
         LOG_INFO("producer finished");
@@ -143,7 +143,7 @@ TEST(ExtensibleLoadManagerTest, testPubSubWhileUnloading) {
             LOG_INFO("acked i:" << i << " " << elapsed << " ms");
             ASSERT_TRUE(elapsed < maxWaitTimeMs);
             ASSERT_EQ(ackResult, ResultOk);
-            consumedMsgs.update(i, i);
+            consumedMsgs.put(i, i);
         }
         LOG_INFO("consumer finished");
     };