Fix buffer overflow in c_BasicEndToEndTest.testAsyncProduceConsume

Author: BewareMyPower

tests/c/c_BasicEndToEndTest.cc

@@ -23,6 +23,7 @@
 #include <string.h>
 
 #include <future>
+#include <iostream>
 
 struct send_ctx {
     pulsar_result result;
@@ -37,13 +38,19 @@ struct receive_ctx {
     std::promise<void> *promise;
 };
 
+static char *copy_string(const char *src) {
+    size_t len = strlen(src);
+    char *dest = (char *)malloc(len + 1);
+    strncpy(dest, src, len);
+    return dest;
+}
+
 static void send_callback(pulsar_result async_result, pulsar_message_id_t *msg_id, void *ctx) {
     struct send_ctx *send_ctx = (struct send_ctx *)ctx;
     send_ctx->result = async_result;
     if (async_result == pulsar_result_Ok) {
         const char *msg_id_str = pulsar_message_id_str(msg_id);
-        send_ctx->msg_id = (char *)malloc(strlen(msg_id_str) * sizeof(char));
-        strcpy(send_ctx->msg_id, msg_id_str);
+        send_ctx->msg_id = copy_string(msg_id_str);
     }
     send_ctx->promise->set_value();
     pulsar_message_id_free(msg_id);
@@ -54,9 +61,7 @@ static void receive_callback(pulsar_result async_result, pulsar_message_t *msg,
     receive_ctx->result = async_result;
     if (async_result == pulsar_result_Ok &&
         pulsar_consumer_acknowledge(receive_ctx->consumer, msg) == pulsar_result_Ok) {
-        const char *data = (const char *)pulsar_message_get_data(msg);
-        receive_ctx->data = (char *)malloc(strlen(data) * sizeof(char));
-        strcpy(receive_ctx->data, data);
+        receive_ctx->data = copy_string((const char *)pulsar_message_get_data(msg));
     }
     receive_ctx->promise->set_value();
     pulsar_message_free(msg);