Skip to content

Commit 0ce4591

Browse files
committed
chore: since go1.20 initialize a random seed is deprecated
1 parent d57f64c commit 0ce4591

File tree

4 files changed

+6
-14
lines changed

4 files changed

+6
-14
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,5 @@ coverage.html
1414
perf/perf
1515
pulsar-perf
1616
bin
17+
18+
vendor/

pulsar/message_chunking_test.go

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,6 @@ func TestInvalidChunkingConfig(t *testing.T) {
5757
}
5858

5959
func TestLargeMessage(t *testing.T) {
60-
rand.Seed(time.Now().Unix())
61-
6260
client, err := NewClient(ClientOptions{
6361
URL: lookupURL,
6462
})
@@ -208,7 +206,6 @@ func TestMaxPendingChunkMessages(t *testing.T) {
208206
}
209207

210208
func TestExpireIncompleteChunks(t *testing.T) {
211-
rand.Seed(time.Now().Unix())
212209
client, err := NewClient(ClientOptions{
213210
URL: lookupURL,
214211
})
@@ -240,8 +237,6 @@ func TestExpireIncompleteChunks(t *testing.T) {
240237
}
241238

242239
func TestChunksEnqueueFailed(t *testing.T) {
243-
rand.Seed(time.Now().Unix())
244-
245240
client, err := NewClient(ClientOptions{
246241
URL: lookupURL,
247242
})
@@ -278,8 +273,6 @@ func TestChunksEnqueueFailed(t *testing.T) {
278273
}
279274

280275
func TestSeekChunkMessages(t *testing.T) {
281-
rand.Seed(time.Now().Unix())
282-
283276
client, err := NewClient(ClientOptions{
284277
URL: lookupURL,
285278
})
@@ -343,8 +336,6 @@ func TestSeekChunkMessages(t *testing.T) {
343336
}
344337

345338
func TestChunkAckAndNAck(t *testing.T) {
346-
rand.Seed(time.Now().Unix())
347-
348339
client, err := NewClient(ClientOptions{
349340
URL: lookupURL,
350341
})
@@ -400,8 +391,6 @@ func TestChunkAckAndNAck(t *testing.T) {
400391
}
401392

402393
func TestChunkSize(t *testing.T) {
403-
rand.Seed(time.Now().Unix())
404-
405394
client, err := NewClient(ClientOptions{
406395
URL: lookupURL,
407396
})

pulsar/producer_partition.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1394,7 +1394,8 @@ func (p *partitionProducer) ReceivedSendReceipt(response *pb.CommandSendReceipt)
13941394
)
13951395

13961396
if sr.totalChunks > 1 {
1397-
if sr.chunkID == 0 {
1397+
switch sr.chunkID {
1398+
case 0:
13981399
sr.chunkRecorder.setFirstChunkID(
13991400
&messageID{
14001401
int64(response.MessageId.GetLedgerId()),
@@ -1403,7 +1404,7 @@ func (p *partitionProducer) ReceivedSendReceipt(response *pb.CommandSendReceipt)
14031404
p.partitionIdx,
14041405
0,
14051406
})
1406-
} else if sr.chunkID == sr.totalChunks-1 {
1407+
case sr.totalChunks - 1:
14071408
sr.chunkRecorder.setLastChunkID(
14081409
&messageID{
14091410
int64(response.MessageId.GetLedgerId()),

pulsar/producer_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1977,8 +1977,8 @@ func TestWaitForExclusiveProducer(t *testing.T) {
19771977
Topic: topicName,
19781978
ProducerAccessMode: ProducerAccessModeWaitForExclusive,
19791979
})
1980-
defer producer2.Close()
19811980
assert.NoError(t, err)
1981+
defer producer2.Close()
19821982
assert.NotNil(t, producer2)
19831983

19841984
id, err := producer2.Send(context.Background(), &ProducerMessage{

0 commit comments

Comments
 (0)