Skip to content

Commit c369e75

Browse files
authored
Remove copy variable in goroutine loop (#1307)
1 parent ffdc3af commit c369e75

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

pulsar/consumer_impl.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -385,16 +385,16 @@ func (c *consumer) internalTopicSubscribeToPartitions() error {
385385
for partitionIdx := startPartition; partitionIdx < newNumPartitions; partitionIdx++ {
386386
partitionTopic := partitions[partitionIdx]
387387

388-
go func(idx int, pt string) {
388+
go func() {
389389
defer wg.Done()
390-
opts := newPartitionConsumerOpts(pt, c.consumerName, idx, c.options)
390+
opts := newPartitionConsumerOpts(partitionTopic, c.consumerName, partitionIdx, c.options)
391391
cons, err := newPartitionConsumer(c, c.client, opts, c.messageCh, c.dlq, c.metrics)
392392
ch <- ConsumerError{
393393
err: err,
394-
partition: idx,
394+
partition: partitionIdx,
395395
consumer: cons,
396396
}
397-
}(partitionIdx, partitionTopic)
397+
}()
398398
}
399399

400400
go func() {
@@ -776,7 +776,6 @@ func (c *consumer) hasNext() bool {
776776

777777
hasNext := make(chan bool)
778778
for _, pc := range c.consumers {
779-
pc := pc
780779
go func() {
781780
defer wg.Done()
782781
if pc.hasNext() {

0 commit comments

Comments
 (0)