Skip to content

Support update or remove topic properties #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BewareMyPower merged 1 commit into from
Jun 9, 2025
Merged

Support update or remove topic properties #1381

BewareMyPower merged 1 commit into from
Jun 9, 2025

Conversation

@BewareMyPower
Copy link
Contributor

@BewareMyPower BewareMyPower commented Jun 9, 2025

Add two methods UpdateProperties and RemoveProperty to Topics. They are the corresponding methods of updateProperties and removeProperties methods in Java.

P.S. Java's removeProperties is confusing. It can only remove one key, so I adopted the RemoveProperty name.

@BewareMyPower BewareMyPower self-assigned this Jun 9, 2025
@BewareMyPower BewareMyPower added this to the v0.16.0 milestone Jun 9, 2025
@BewareMyPower
Copy link
Contributor Author

BewareMyPower commented Jun 9, 2025

TestMessageSingleRouter is really flaky. Let me rerun again.

@BewareMyPower BewareMyPower merged commit 5cdb227 into apache:master Jun 9, 2025
7 checks passed
@BewareMyPower BewareMyPower deleted the bewaremypower/admin-update-topic-props branch June 9, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nodece nodece nodece approved these changes

@RobertIndie RobertIndie RobertIndie approved these changes

@crossoverJie crossoverJie Awaiting requested review from crossoverJie

@shibd shibd Awaiting requested review from shibd

Assignees

@BewareMyPower BewareMyPower

Labels

None yet

Projects

None yet

Milestone

v0.16.0

Development

Successfully merging this pull request may close these issues.

3 participants

@BewareMyPower @nodece @RobertIndie