fix: respect context cancellation in async producer #1420
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The async producer was not honoring the context passed to SendAsync,
which violated Go's context conventions. When the Pulsar broker connection
was lost, the producer would continue attempting to send messages indefinitely.
Changes:
- Check context cancellation in the event loop before processing send requests
- Check context before processing internalSend
- Use the original request context when writing data instead of creating new one
- Add context checking in clearPendingSendRequests
This ensures that when a context is canceled (due to timeout or manual cancellation),
the send operation will fail immediately with ErrContextExpired instead of blocking
indefinitely.
Fixes: streamnative/eng-support-tickets#3170
Contributor
|
Close AI PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.