FIX: Fixed inconsistent c++ method implementation, removed unnecessary TODO

Author: nl-x-net

src/client.cc

@@ -55,9 +55,8 @@ Consumer Client_subscribe_topics(Client& client, const std::vector<std::string>&
 }
 
 void Client_subscribe_topicsAsync(Client& client, const std::vector<std::string>& topics, const std::string& subscriptionName, const ConsumerConfiguration& conf, SubscribeCallback callback){
-    client.subscribeAsync(topics, subscriptionName, conf, [callback](Result result, pulsar::Consumer consumer){
-        callback(result, consumer);
-    });
+    py::gil_scoped_release release;
+    client.subscribeAsync(topics, subscriptionName, conf, callback);
 }
 
 Consumer Client_subscribe_pattern(Client& client, const std::string& topic_pattern,
@@ -68,10 +67,8 @@ Consumer Client_subscribe_pattern(Client& client, const std::string& topic_patte
 }
 
 void Client_subscribe_patternAsync(Client& client, const std::string& topic_pattern, const std::string& subscriptionName, const ConsumerConfiguration& conf, SubscribeCallback callback){
-    client.subscribeWithRegexAsync(topic_pattern, subscriptionName, conf, [callback](Result result, Consumer consumer){
-        py::gil_scoped_acquire acquire;
-        callback(result, consumer);
-    });
+      py::gil_scoped_release release;
+      client.subscribeWithRegexAsync(topic_pattern, subscriptionName, conf, callback);
 }
 
 Reader Client_createReader(Client& client, const std::string& topic, const MessageId& startMessageId,

src/consumer.cc

@@ -4,7 +4,7 @@
  * distributed with this work for additional information
  * regarding copyright ownership.  The ASF licenses this file
  * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except
+ * "License"); you may not use this file except in compliance
  * with the License.  You may obtain a copy of the License at
  *
  *   http://www.apache.org/licenses/LICENSE-2.0

tests/asyncio_test.py

@@ -34,8 +34,6 @@
     IsolatedAsyncioTestCase,
 )
 
-# TODO: Write tests for everything else
-
 service_url = 'pulsar://localhost'
 
 class AsyncioTest(IsolatedAsyncioTestCase):
@@ -68,7 +66,7 @@ async def test_create_producer_failure(self):
             await self._client.create_producer('tenant/ns/awaitio-test-send-failure')
             self.fail()
         except PulsarException as e:
-            self.assertEqual(e.error(), pulsar.Result.Timeout)
+            self.assertEqual(e.error(), pulsar.Result.TopicNotFound)
 
     async def test_send_failure(self):
         producer = await self._client.create_producer('awaitio-test-send-failure')