Skip to content

Commit 80999ff

Browse files
authored
Use BookKeeper BP-29 metadataServiceUri to configure bookie metadata store, also when using Zookeeper (#585)
1 parent 87b48d0 commit 80999ff

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

charts/pulsar/templates/_bookkeeper.tpl

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,14 +97,22 @@ Define bookie tls certs volumes
9797
Define bookie common config
9898
*/}}
9999
{{- define "pulsar.bookkeeper.config.common" -}}
100+
{{/*
101+
Configure BookKeeper's metadata store (available since BookKeeper 4.7.0 / BP-29)
102+
https://bookkeeper.apache.org/bps/BP-29-metadata-store-api-module/
103+
https://bookkeeper.apache.org/docs/deployment/manual#cluster-metadata-setup
104+
*/}}
105+
# Set empty values for zkServers and zkLedgersRootPath since we're using the metadataServiceUri to configure BookKeeper's metadata store
106+
zkServers: ""
107+
zkLedgersRootPath: ""
100108
{{- if .Values.components.zookeeper }}
101109
{{- if (and (hasKey .Values.pulsar_metadata "bookkeeper") .Values.pulsar_metadata.bookkeeper.usePulsarMetadataBookieDriver) }}
102110
# there's a bug when using PulsarMetadataBookieDriver since it always appends /ledgers to the metadataServiceUri
103111
# Possibly a bug in org.apache.pulsar.metadata.bookkeeper.AbstractMetadataDriver#resolveLedgersRootPath in Pulsar code base
104112
metadataServiceUri: "metadata-store:zk:{{ template "pulsar.zookeeper.connect" . }}{{ .Values.metadataPrefix }}"
105113
{{- else }}
106-
zkServers: "{{ template "pulsar.zookeeper.connect" . }}"
107-
zkLedgersRootPath: "{{ .Values.metadataPrefix }}/ledgers"
114+
# use zk+hierarchical:// when using BookKeeper's built-in metadata driver
115+
metadataServiceUri: "zk+hierarchical://{{ template "pulsar.zookeeper.connect" . }}{{ .Values.metadataPrefix }}/ledgers"
108116
{{- end }}
109117
{{- else if .Values.components.oxia }}
110118
metadataServiceUri: "{{ template "pulsar.oxia.metadata.url.bookkeeper" . }}"

0 commit comments

Comments
 (0)