[fix][test] Use PositionFactory.create() instead of new ImmutablePositionImpl()

Author: oneby-wang

managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorTest.java

@@ -1285,7 +1285,7 @@ void cursorPersistence() throws Exception {
         assertEquals(c1.getMarkDeletedPosition(), p1);
         ManagedCursor finalC2 = c2;
         Awaitility.await()
-                .untilAsserted(() -> assertEquals(finalC2.getMarkDeletedPosition(), new ImmutablePositionImpl(6, -1)));
+                .untilAsserted(() -> assertEquals(finalC2.getMarkDeletedPosition(), PositionFactory.create(6, -1)));
     }
 
     @Test(timeOut = 20000)
@@ -1422,8 +1422,8 @@ public void markDeleteComplete(Object ctx) {
         Awaitility.await().untilAsserted(() ->
                 assertTrue(
                         c2.getMarkDeletedPosition().equals(lastPosition.get())
-                        || c2.getMarkDeletedPosition().equals(new ImmutablePositionImpl(lastPositionLedgerId + 2, -1))
-                        || c2.getMarkDeletedPosition().equals(new ImmutablePositionImpl(lastPositionLedgerId + 3, -1))
+                        || c2.getMarkDeletedPosition().equals(PositionFactory.create(lastPositionLedgerId + 2, -1))
+                        || c2.getMarkDeletedPosition().equals(PositionFactory.create(lastPositionLedgerId + 3, -1))
                 )
         );
     }
@@ -1464,7 +1464,7 @@ public void addComplete(Position position, ByteBuf entryData, Object ctx) {
             }, null);
         }
         addEntryLatch.await();
-        assertEquals(lastPosition.get(), new ImmutablePositionImpl(13, 0));
+        assertEquals(lastPosition.get(), PositionFactory.create(13, 0));
 
         // If we set num=100, to avoid flaky test, we should add Thread.sleep(1000) here to make sure ledger rollover
         // is finished, but this sleep can not guarantee c1 always recovered with markDeletePosition 12:9.
@@ -1513,7 +1513,7 @@ public void markDeleteComplete(Object ctx) {
         // To make sure ManagedLedgerImpl.maybeUpdateCursorBeforeTrimmingConsumedLedger() is completed, we should
         // wait until c2.getMarkDeletedPosition() equals 15:-1, see PR https://github.com/apache/pulsar/pull/25087.
         Awaitility.await()
-                .untilAsserted(() -> assertEquals(c2.getMarkDeletedPosition(), new ImmutablePositionImpl(15, -1)));
+                .untilAsserted(() -> assertEquals(c2.getMarkDeletedPosition(), PositionFactory.create(15, -1)));
     }
 
     @Test(timeOut = 20000)
@@ -1565,9 +1565,8 @@ public void markDeleteComplete(Object ctx) {
         log.info("c2 markDeletePosition: {}, lastPosition: {}", c2.getMarkDeletedPosition(), lastPosition);
         long lastPositionLedgerId = lastPosition.get().getLedgerId();
         Awaitility.await().untilAsserted(() -> assertTrue(
-                c2.getMarkDeletedPosition().equals(new ImmutablePositionImpl(lastPositionLedgerId + 1, -1))
-                        || c2.getMarkDeletedPosition()
-                        .equals(new ImmutablePositionImpl(lastPositionLedgerId + 2, -1))));
+                c2.getMarkDeletedPosition().equals(PositionFactory.create(lastPositionLedgerId + 1, -1))
+                        || c2.getMarkDeletedPosition().equals(PositionFactory.create(lastPositionLedgerId + 2, -1))));
     }
 
     @Test(timeOut = 20000)