Skip to content

Commit 608f838

Browse files
committed
[fix][ci] Fix jacoco code coverage report aggregation
1 parent 10eeacc commit 608f838

File tree

3 files changed

+16
-4
lines changed

3 files changed

+16
-4
lines changed

build/pulsar_ci_tool.sh

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -353,6 +353,7 @@ _ci_upload_coverage_files() {
353353
--transform="flags=r;s|\\(/jacoco.*\\).exec$|\\1_${testtype}_${testgroup}.exec|" \
354354
--transform="flags=r;s|\\(/tmp/jacocoDir/.*\\).exec$|\\1_${testtype}_${testgroup}.exec|" \
355355
--exclude="*/META-INF/bundled-dependencies/*" \
356+
--exclude="*/META-INF/versions/*" \
356357
$GITHUB_WORKSPACE/target/classpath_* \
357358
$(find "$GITHUB_WORKSPACE" -path "*/target/jacoco*.exec" -printf "%p\n%h/classes\n" | sort | uniq) \
358359
$([ -d /tmp/jacocoDir ] && echo "/tmp/jacocoDir" ) \
@@ -494,11 +495,11 @@ ci_create_test_coverage_report() {
494495
local classfilesArgs="--classfiles $({
495496
{
496497
for classpathEntry in $(cat $completeClasspathFile | { grep -v -f $filterArtifactsFile || true; } | sort | uniq | { grep -v -E "$excludeJarsPattern" || true; }); do
497-
if [[ -f $classpathEntry && -n "$(unzip -Z1C $classpathEntry 'META-INF/bundled-dependencies/*' 2>/dev/null)" ]]; then
498-
# file must be processed by removing META-INF/bundled-dependencies
498+
if [[ -f $classpathEntry && -n "$(unzip -Z1C $classpathEntry 'META-INF/bundled-dependencies/*' 'META-INF/versions/*' 2>/dev/null)" ]]; then
499+
# file must be processed by removing META-INF/bundled-dependencies and META-INF/versions
499500
local jartempfile=$(mktemp -t jarfile.XXXX --suffix=.jar)
500501
cp $classpathEntry $jartempfile
501-
zip -q -d $jartempfile 'META-INF/bundled-dependencies/*' &> /dev/null
502+
zip -q -d $jartempfile 'META-INF/bundled-dependencies/*' 'META-INF/versions/*' &> /dev/null
502503
echo $jartempfile
503504
else
504505
echo $classpathEntry

jetcd-core-shaded/pom.xml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,12 @@
100100
<pattern>io.vertx</pattern>
101101
<shadedPattern>org.apache.pulsar.jetcd.shaded.io.vertx</shadedPattern>
102102
</relocation>
103+
<!-- relocate multi-release packages -->
104+
<relocation>
105+
<pattern>META-INF/versions/(\d+)/io/vertx/</pattern>
106+
<shadedPattern>META-INF/versions/$1/org/apache/pulsar/jetcd/shaded/io/vertx/</shadedPattern>
107+
<rawString>true</rawString>
108+
</relocation>
103109
<!-- relocate to use grpc-netty-shaded packages -->
104110
<relocation>
105111
<pattern>io.grpc.netty</pattern>
@@ -123,6 +129,11 @@
123129
</filter>
124130
</filters>
125131
<transformers>
132+
<transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
133+
<manifestEntries>
134+
<Multi-Release>true</Multi-Release>
135+
</manifestEntries>
136+
</transformer>
126137
<transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/>
127138
<transformer implementation="org.apache.maven.plugins.shade.resource.PluginXmlResourceTransformer"/>
128139
<transformer implementation="org.apache.maven.plugins.shade.resource.IncludeResourceTransformer">

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ flexible messaging model and an intuitive client API.</description>
309309
<git-commit-id-plugin.version>4.9.10</git-commit-id-plugin.version>
310310
<wagon-ssh-external.version>3.5.3</wagon-ssh-external.version>
311311
<os-maven-plugin.version>1.7.0</os-maven-plugin.version>
312-
<jacoco-maven-plugin.version>0.8.11</jacoco-maven-plugin.version>
312+
<jacoco-maven-plugin.version>0.8.12</jacoco-maven-plugin.version>
313313
<spotbugs-maven-plugin.version>4.7.3.6</spotbugs-maven-plugin.version>
314314
<spotbugs.version>4.7.3</spotbugs.version>
315315
<errorprone.version>2.24.0</errorprone.version>

0 commit comments

Comments
 (0)