Skip to content

Commit 053683f

Browse files
authored
RATIS-2232. Improve log for debugging on RaftLog / TransactionManager (#1203)
1 parent 320b207 commit 053683f

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

ratis-server-api/src/main/java/org/apache/ratis/server/raftlog/RaftLogSequentialOps.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,10 @@ <OUTPUT, THROWABLE extends Throwable> OUTPUT runSequentially(
7979
// The current thread is already the runner.
8080
return operation.get();
8181
} else {
82+
final Throwable cause = new Throwable("The thread already running: " + previous);
83+
cause.setStackTrace(previous.getStackTrace());
8284
throw new IllegalStateException(
83-
name + ": Already running a method by " + previous + ", current=" + current);
85+
name + ": Already running a method by " + previous + ", current=" + current, cause);
8486
}
8587
}
8688
}

ratis-server/src/main/java/org/apache/ratis/server/impl/TransactionManager.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,6 @@ void remove(TermIndex termIndex) {
7171

7272
@Override
7373
public String toString() {
74-
if (contexts.isEmpty()) {
75-
return name + " <empty>";
76-
}
77-
78-
final StringBuilder b = new StringBuilder(name);
79-
contexts.forEach((k, v) -> b.append("\n ").append(k).append(": initialized? ").append(v.isInitialized()));
80-
return b.toString();
74+
return name + ":size=" + contexts.size();
8175
}
8276
}

0 commit comments

Comments
 (0)