Skip to content

Commit 72c1765

Browse files
RATIS-2269. Remove all import java.util.* statements. (#1243)
1 parent 93ab53c commit 72c1765

File tree

17 files changed

+110
-19
lines changed

17 files changed

+110
-19
lines changed

ratis-common/src/main/java/org/apache/ratis/protocol/RaftGroup.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,13 @@
1919

2020
import org.apache.ratis.util.Preconditions;
2121

22-
import java.util.*;
22+
import java.util.Arrays;
23+
import java.util.Collection;
24+
import java.util.Collections;
25+
import java.util.HashMap;
26+
import java.util.Map;
27+
import java.util.Objects;
28+
2329

2430
/**
2531
* Description of a raft group, which has a unique {@link RaftGroupId} and a collection of {@link RaftPeer}.

ratis-common/src/main/java/org/apache/ratis/util/CollectionUtils.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,14 @@
1717
*/
1818
package org.apache.ratis.util;
1919

20-
import java.util.*;
20+
import java.util.ArrayList;
21+
import java.util.Arrays;
22+
import java.util.Collection;
23+
import java.util.Comparator;
24+
import java.util.Iterator;
25+
import java.util.List;
26+
import java.util.Map;
27+
import java.util.Objects;
2128
import java.util.concurrent.ConcurrentMap;
2229
import java.util.concurrent.ThreadLocalRandom;
2330
import java.util.function.BiFunction;

ratis-common/src/main/java/org/apache/ratis/util/FileUtils.java

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,18 @@
2727
import java.io.OutputStream;
2828
import java.nio.ByteBuffer;
2929
import java.nio.channels.FileChannel;
30-
import java.nio.file.*;
30+
import java.nio.file.AtomicMoveNotSupportedException;
31+
import java.nio.file.CopyOption;
32+
import java.nio.file.FileAlreadyExistsException;
33+
import java.nio.file.FileVisitResult;
34+
import java.nio.file.Files;
35+
import java.nio.file.LinkOption;
36+
import java.nio.file.OpenOption;
37+
import java.nio.file.Path;
38+
import java.nio.file.Paths;
39+
import java.nio.file.SimpleFileVisitor;
40+
import java.nio.file.StandardCopyOption;
41+
import java.nio.file.StandardOpenOption;
3142
import java.nio.file.attribute.BasicFileAttributes;
3243
import java.util.Arrays;
3344
import java.util.List;

ratis-common/src/main/java/org/apache/ratis/util/NetUtils.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,13 @@
2323
import org.slf4j.LoggerFactory;
2424

2525
import java.io.IOException;
26-
import java.net.*;
26+
import java.net.Inet6Address;
27+
import java.net.InetAddress;
28+
import java.net.InetSocketAddress;
29+
import java.net.ServerSocket;
30+
import java.net.URI;
31+
import java.net.URISyntaxException;
32+
import java.net.UnknownHostException;
2733
import java.util.ArrayList;
2834
import java.util.List;
2935
import java.util.Map;

ratis-common/src/main/java/org/apache/ratis/util/ReflectionUtils.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,17 @@
2020

2121
package org.apache.ratis.util;
2222

23-
2423
import java.lang.ref.WeakReference;
2524
import java.lang.reflect.Constructor;
2625
import java.lang.reflect.InvocationTargetException;
27-
import java.util.*;
26+
import java.util.ArrayList;
27+
import java.util.Arrays;
28+
import java.util.Collections;
29+
import java.util.List;
30+
import java.util.Map;
31+
import java.util.Objects;
32+
import java.util.Optional;
33+
import java.util.WeakHashMap;
2834
import java.util.concurrent.ConcurrentHashMap;
2935

3036
/**

ratis-examples/src/test/java/org/apache/ratis/examples/ParameterizedBaseTest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,12 @@
3535
import org.slf4j.LoggerFactory;
3636

3737
import java.io.IOException;
38-
import java.util.*;
38+
import java.util.ArrayList;
39+
import java.util.Arrays;
40+
import java.util.Collection;
41+
import java.util.Collections;
42+
import java.util.Iterator;
43+
import java.util.List;
3944
import java.util.concurrent.TimeUnit;
4045
import java.util.concurrent.atomic.AtomicReference;
4146

ratis-examples/src/test/java/org/apache/ratis/examples/filestore/FileStoreAsyncBaseTest.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,11 @@
3232
import java.io.File;
3333
import java.util.ArrayList;
3434
import java.util.List;
35-
import java.util.concurrent.*;
35+
import java.util.concurrent.Callable;
36+
import java.util.concurrent.CompletableFuture;
37+
import java.util.concurrent.Executor;
38+
import java.util.concurrent.ExecutorService;
39+
import java.util.concurrent.Executors;
3640

3741
public abstract class FileStoreAsyncBaseTest<CLUSTER extends MiniRaftCluster>
3842
extends BaseTest

ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcLogAppender.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,13 @@
5151

5252
import java.io.IOException;
5353
import java.io.InterruptedIOException;
54-
import java.util.*;
54+
import java.util.Comparator;
55+
import java.util.LinkedList;
56+
import java.util.Map;
57+
import java.util.Objects;
58+
import java.util.Optional;
59+
import java.util.Queue;
60+
import java.util.UUID;
5561
import java.util.concurrent.CompletableFuture;
5662
import java.util.concurrent.ConcurrentHashMap;
5763
import java.util.concurrent.ExecutionException;

ratis-server/src/main/java/org/apache/ratis/server/impl/ConfigurationManager.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,10 @@
2525
import org.apache.ratis.util.Preconditions;
2626
import org.apache.ratis.util.StringUtils;
2727

28-
import java.util.*;
28+
import java.util.NavigableMap;
29+
import java.util.SortedMap;
30+
import java.util.TreeMap;
31+
2932

3033
/**
3134
* Maintain the mappings between log index and corresponding raft configuration.

ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerProxy.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,12 @@
6767
import java.util.Objects;
6868
import java.util.Optional;
6969
import java.util.UUID;
70-
import java.util.concurrent.*;
70+
import java.util.concurrent.CompletableFuture;
71+
import java.util.concurrent.CompletionException;
72+
import java.util.concurrent.ConcurrentHashMap;
73+
import java.util.concurrent.ConcurrentMap;
74+
import java.util.concurrent.ExecutorService;
75+
import java.util.concurrent.TimeUnit;
7176
import java.util.function.Predicate;
7277
import java.util.function.Supplier;
7378
import java.util.stream.Collectors;

0 commit comments

Comments
 (0)