RATIS-2291. Fix failing TestInstallSnapshotNotificationWithGrpc#testAddNewFollowersNoSnapshot. (#1257)

Author: slfan1989

ratis-server/src/test/java/org/apache/ratis/InstallSnapshotNotificationTests.java

@@ -220,7 +220,7 @@ private void testAddNewFollowers(CLUSTER cluster, int numRequests) throws Except
     // delete the log segments from the leader
     LOG.info("Delete logs {}", logs);
     for (LogSegmentPath path : logs) {
-      FileUtils.deleteFully(path.getPath()); // the log may be already puged
+      FileUtils.deleteFully(path.getPath()); // the log may be already purged
     }
 
     // restart the peer
@@ -252,7 +252,7 @@ private void testAddNewFollowers(CLUSTER cluster, int numRequests) throws Except
       // Check the installed snapshot index on each Follower matches with the
       // leader snapshot.
       for (RaftServer.Division follower : cluster.getFollowers()) {
-        final long expected = shouldInstallSnapshot ? leaderSnapshotInfo.getIndex() : RaftLog.INVALID_LOG_INDEX;
+        final long expected = leaderSnapshotInfo.getIndex();
         Assert.assertEquals(expected, RaftServerTestUtil.getLatestInstalledSnapshotIndex(follower));
         RaftSnapshotBaseTest.assertLogContent(follower, false);
       }

ratis-server/src/test/java/org/apache/ratis/server/impl/MiniRaftCluster.java

@@ -134,7 +134,7 @@ default void runWithNewCluster(int numServers, int numListeners, CheckedConsumer
       default void runWithNewCluster(int numServers, int numListeners, boolean startCluster,
           CheckedConsumer<CLUSTER, Exception> testCase) throws Exception {
         final StackTraceElement caller = JavaUtils.getCallerStackTraceElement();
-        LOG.info("Running " + caller.getMethodName());
+        LOG.info("Running {}", caller.getMethodName());
         final CLUSTER cluster = newCluster(numServers, numListeners);
         Throwable failed = null;
         try {
@@ -144,7 +144,7 @@ default void runWithNewCluster(int numServers, int numListeners, boolean startCl
           testCase.accept(cluster);
         } catch(Throwable t) {
           LOG.info(cluster.printServers());
-          LOG.error("Failed " + caller, t);
+          LOG.error("Failed {}", caller, t);
           failed = t;
           throw t;
         } finally {
@@ -167,7 +167,7 @@ default void runWithSameCluster(int numServers, CheckedConsumer<CLUSTER, Excepti
       default void runWithSameCluster(int numServers, int numListeners, CheckedConsumer<CLUSTER, Exception> testCase)
           throws Exception {
         final StackTraceElement caller = JavaUtils.getCallerStackTraceElement();
-        LOG.info("Running " + caller.getMethodName());
+        LOG.info("Running {}", caller.getMethodName());
         CLUSTER cluster = null;
         try {
           cluster = getFactory().reuseCluster(numServers, numListeners, getProperties());
@@ -176,7 +176,7 @@ default void runWithSameCluster(int numServers, int numListeners, CheckedConsume
           if (cluster != null) {
             LOG.info(cluster.printServers());
           }
-          LOG.error("Failed " + caller, t);
+          LOG.error("Failed {}", caller, t);
           throw t;
         }
       }
@@ -328,7 +328,7 @@ public RaftProperties getProperties() {
   }
 
   public MiniRaftCluster initServers() {
-    LOG.info("servers = " + servers);
+    LOG.info("servers = {}", servers);
     if (servers.isEmpty()) {
       putNewServers(CollectionUtils.as(group.getPeers(), RaftPeer::getId), true, group);
     }
@@ -359,7 +359,7 @@ public void start() throws IOException {
     startServers(servers.values());
 
     this.timer.updateAndGet(t -> t != null? t
-        : JavaUtils.runRepeatedly(() -> LOG.info("TIMED-PRINT: " + printServers()), 10, 10, TimeUnit.SECONDS));
+        : JavaUtils.runRepeatedly(() -> LOG.info("TIMED-PRINT: {}.", printServers()), 10, 10, TimeUnit.SECONDS));
   }
 
   /**
@@ -546,7 +546,7 @@ public PeerChanges removePeers(int number, boolean removeLeader,
   }
 
   public void killServer(RaftPeerId id) {
-    LOG.info("killServer " + id);
+    LOG.info("killServer {}", id);
     servers.get(id).close();
   }