[ISSUE #9765] Improve null handling in file operations (#9766)

yx9o · web-flow · commit 6da83face23b · 2025-10-21T16:26:40.000+08:00
diff --git a/common/src/main/java/org/apache/rocketmq/common/UtilAll.java b/common/src/main/java/org/apache/rocketmq/common/UtilAll.java
@@ -645,8 +645,10 @@ public static void deleteFile(File file) {
             file.delete();
         } else if (file.isDirectory()) {
             File[] files = file.listFiles();
-            for (File file1 : files) {
-                deleteFile(file1);
+            if (files != null) {
+                for (File file1 : files) {
+                    deleteFile(file1);
+                }
             }
             file.delete();
         }

Original file line number	Diff line number	Diff line change
`@@ -645,8 +645,10 @@ public static void deleteFile(File file) {`
`645`	`645`	`file.delete();`
`646`	`646`	`} else if (file.isDirectory()) {`
`647`	`647`	`File[] files = file.listFiles();`
`648`		`- for (File file1 : files) {`
`649`		`- deleteFile(file1);`
	`648`	`+ if (files != null) {`
	`649`	`+ for (File file1 : files) {`
	`650`	`+ deleteFile(file1);`
	`651`	`+ }`
`650`	`652`	`}`
`651`	`653`	`file.delete();`
`652`	`654`	`}`