Skip to content

Commit fb2a03f

Browse files
committed
fix unit test
Change-Id: I27013578ad6be9d2c1153c741f29e40d00714e30
1 parent 7ee2faf commit fb2a03f

File tree

5 files changed

+11
-6
lines changed

5 files changed

+11
-6
lines changed

common/src/main/java/org/apache/rocketmq/common/message/MessageConst.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,5 @@ public class MessageConst {
159159
STRING_HASH_SET.add(PROPERTY_DLQ_ORIGIN_MESSAGE_ID);
160160
STRING_HASH_SET.add(PROPERTY_CRC32);
161161
STRING_HASH_SET.add(PROPERTY_LITE_TOPIC);
162-
STRING_HASH_SET.add(PROPERTY_INNER_MULTI_DISPATCH);
163162
}
164163
}

proxy/src/test/java/org/apache/rocketmq/proxy/processor/ConsumerProcessorTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,11 +108,11 @@ public void testPopMessage() throws Throwable {
108108
.thenReturn(mock(MessageQueueView.class));
109109

110110
ArgumentCaptor<String> ackMessageIdArgumentCaptor = ArgumentCaptor.forClass(String.class);
111-
when(this.messagingProcessor.ackMessage(any(), any(), ackMessageIdArgumentCaptor.capture(), anyString(), anyString(), anyLong()))
111+
when(this.messagingProcessor.ackMessage(any(), any(), ackMessageIdArgumentCaptor.capture(), anyString(), anyString(), any(), anyLong()))
112112
.thenReturn(CompletableFuture.completedFuture(mock(AckResult.class)));
113113

114114
ArgumentCaptor<String> toDLQMessageIdArgumentCaptor = ArgumentCaptor.forClass(String.class);
115-
when(this.messagingProcessor.forwardMessageToDeadLetterQueue(any(), any(), toDLQMessageIdArgumentCaptor.capture(), anyString(), anyString(), anyLong()))
115+
when(this.messagingProcessor.forwardMessageToDeadLetterQueue(any(), any(), toDLQMessageIdArgumentCaptor.capture(), anyString(), anyString(), any(), anyLong()))
116116
.thenReturn(CompletableFuture.completedFuture(mock(RemotingCommand.class)));
117117

118118
AddressableMessageQueue messageQueue = mock(AddressableMessageQueue.class);

proxy/src/test/java/org/apache/rocketmq/proxy/processor/ReceiptHandleProcessorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public void testStart() throws Exception {
9595
Mockito.when(consumerManager.findChannel(Mockito.eq(CONSUMER_GROUP), Mockito.eq(PROXY_CONTEXT.getChannel()))).thenReturn(Mockito.mock(ClientChannelInfo.class));
9696
Mockito.verify(messagingProcessor, Mockito.timeout(10000).times(1))
9797
.changeInvisibleTime(Mockito.any(ProxyContext.class), Mockito.any(ReceiptHandle.class), Mockito.eq(MESSAGE_ID),
98-
Mockito.eq(CONSUMER_GROUP), Mockito.eq(TOPIC), Mockito.eq(ConfigurationManager.getProxyConfig().getDefaultInvisibleTimeMills()));
98+
Mockito.eq(CONSUMER_GROUP), Mockito.eq(TOPIC), Mockito.eq(ConfigurationManager.getProxyConfig().getDefaultInvisibleTimeMills()), Mockito.eq(null));
9999
}
100100

101101
}

test/src/test/java/org/apache/rocketmq/test/grpc/v2/GrpcBaseIT.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,7 @@ public void testQueryFifoAssignment() throws Exception {
257257
public void testTransactionCheckThenCommit() {
258258
String topic = initTopicOnSampleTopicBroker(BROKER1_NAME, TopicMessageType.TRANSACTION);
259259
String group = MQRandomUtils.getRandomConsumerGroup();
260+
initConsumerGroup(group);
260261

261262
AtomicReference<TelemetryCommand> telemetryCommandRef = new AtomicReference<>(null);
262263
StreamObserver<TelemetryCommand> requestStreamObserver = stub.telemetry(new DefaultTelemetryCommandStreamObserver() {
@@ -351,6 +352,7 @@ public void testSimpleConsumerSendAndRecvDelayMessage() throws Exception {
351352
String topic = initTopicOnSampleTopicBroker(BROKER1_NAME, TopicMessageType.DELAY);
352353
String group = MQRandomUtils.getRandomConsumerGroup();
353354
long delayTime = TimeUnit.SECONDS.toMillis(5);
355+
initConsumerGroup(group);
354356

355357
// init consumer offset
356358
this.sendClientSettings(stub, buildSimpleConsumerClientSettings(group)).get();
@@ -398,6 +400,7 @@ public void testSimpleConsumerSendAndRecvDelayMessage() throws Exception {
398400
public void testSimpleConsumerSendAndRecallDelayMessage() throws Exception {
399401
String topic = initTopicOnSampleTopicBroker(BROKER1_NAME, TopicMessageType.DELAY);
400402
String group = MQRandomUtils.getRandomConsumerGroup();
403+
initConsumerGroup(group);
401404
long delayTime = TimeUnit.SECONDS.toMillis(5);
402405

403406
// init consumer offset
@@ -461,6 +464,7 @@ public void testSimpleConsumerSendAndRecallDelayMessage() throws Exception {
461464
public void testSimpleConsumerSendAndRecvBigMessage() throws Exception {
462465
String topic = initTopicOnSampleTopicBroker(BROKER1_NAME);
463466
String group = MQRandomUtils.getRandomConsumerGroup();
467+
initConsumerGroup(group);
464468

465469
int bodySize = 4 * 1024;
466470

@@ -483,6 +487,7 @@ public void testSimpleConsumerSendAndRecvBigMessage() throws Exception {
483487
public void testSimpleConsumerSendAndRecv() throws Exception {
484488
String topic = initTopicOnSampleTopicBroker(BROKER1_NAME);
485489
String group = MQRandomUtils.getRandomConsumerGroup();
490+
initConsumerGroup(group);
486491

487492
// init consumer offset
488493
this.sendClientSettings(stub, buildSimpleConsumerClientSettings(group)).get();
@@ -539,6 +544,7 @@ public void testSimpleConsumerSendAndRecv() throws Exception {
539544
public void testSimpleConsumerToDLQ() throws Exception {
540545
String topic = initTopicOnSampleTopicBroker(BROKER1_NAME);
541546
String group = MQRandomUtils.getRandomConsumerGroup();
547+
initConsumerGroup(group);
542548
int maxDeliveryAttempts = 2;
543549

544550
SubscriptionGroupConfig groupConfig = brokerController1.getSubscriptionGroupManager().findSubscriptionGroupConfig(group);

test/src/test/java/org/apache/rocketmq/test/lmq/TestBenchLmqStore.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,8 @@ public void test() throws MQBrokerException, RemotingException, InterruptedExcep
6161
System.setProperty("pullConsumerNum", "1");
6262
System.setProperty("consumerThreadNum", "1");
6363
BenchLmqStore.defaultMQProducer = mock(DefaultMQProducer.class);
64-
SendResult sendResult = new SendResult();
65-
when(BenchLmqStore.defaultMQProducer.send(any(Message.class))).thenReturn(sendResult);
64+
// SendResult sendResult = new SendResult();
65+
// when(BenchLmqStore.defaultMQProducer.send(any(Message.class))).thenReturn(sendResult);
6666
BenchLmqStore.doSend();
6767
Thread.sleep(100L);
6868
//verify(BenchLmqStore.defaultMQProducer, atLeastOnce()).send(any(Message.class));

0 commit comments

Comments
 (0)