fix(r/sedonadb): Fix build on Windows for path restriction (#208)

This PR allows a developer to override the target path for Cargo, which is useful on Windows where most paths a user might build this under fail (e.g., I run into the path length restriction for CMake in my usual home directory/documents folder). This allows overriding that (for local development it one can put SEDONADB_TARGET_DIR=C:/sedonadb_tmp in their .Rprofile), and automatically overrides it on GitHub actions (where R Universe Windows packages are built).

Author: paleolimbot

r/sedonadb/configure.win

@@ -56,6 +56,20 @@ RUSTC_VERSION="$(rustc --version || true)"
 echo "using Rust package manager: '${CARGO_VERSION}'"
 echo "using Rust compiler: '${RUSTC_VERSION}'"
 
+# If we are in GitHub actions (e.g., R Universe), set the target directory
+# to a very, very short path. If we don't do this, we run out of path length
+# to compile components of the aws-lc-sys crate. This also lets us better
+# cache the compilation.
+if [ -n "$SEDONADB_TARGET_DIR" ];then
+  TARGET_DIR="$SEDONADB_TARGET_DIR"
+elif [ -n "$GITHUB_ACTIONS" ]; then
+  mkdir C:/sedonadb_tmp
+  TARGET_DIR="C:/sedonadb_tmp"
+else
+  TARGET_DIR="$(pwd)/src/rust/target"
+fi
+
+
 # allow overriding profile externally (e.g. on CI)
 if [ -n "${SAVVY_PROFILE}" ]; then
   PROFILE="${SAVVY_PROFILE}"
@@ -74,6 +88,7 @@ fi
 sed \
   -e "s/@TARGET@/x86_64-pc-windows-gnu/" \
   -e "s/@PROFILE@/${PROFILE}/" \
+  -e "s|@TARGET_DIR@|${TARGET_DIR}|" \
   -e "s/@FEATURE_FLAGS@/${FEATURE_FLAGS}/" \
   -e "s|@PKG_LIBS@|${PKG_LIBS}|" \
   src/Makevars.win.in > src/Makevars.win

r/sedonadb/src/Makevars.win.in

@@ -23,7 +23,8 @@ FEATURE_FLAGS = @FEATURE_FLAGS@
 # Add flags if necessary
 RUSTFLAGS =
 
-TARGET_DIR = $(CURDIR)/rust/target
+# We set this in configure to work around a Windows path length restriction
+TARGET_DIR = @TARGET_DIR@
 LIBDIR = $(TARGET_DIR)/$(TARGET)/$(subst dev,debug,$(PROFILE))
 STATLIB = $(LIBDIR)/libsedonadbr.a
 PKG_LIBS = -L$(LIBDIR) -lsedonadbr -lws2_32 -ladvapi32 -luserenv -lbcrypt -lntdll  @PKG_LIBS@
@@ -57,7 +58,6 @@ $(STATLIB):
 	  export PKG_CONFIG_SYSROOT_DIR="$(PKG_CONFIG_SYSROOT_DIR)" && \
 	  export CC="$(CC)" && \
 	  export CFLAGS="$(CFLAGS_TWEAKED)" && \
-	  export CMAKE_TOOLCHAIN_FILE="$(CURDIR)/rust/aws-lc-sys-win-toolchain.cmake" && \
 	  export RUSTFLAGS="$(RUSTFLAGS)" && \
 	  cargo build --target $(TARGET) --lib --profile $(PROFILE) $(FEATURE_FLAGS) --manifest-path ./rust/Cargo.toml --target-dir $(TARGET_DIR)