chore(c/sedona-geoarrow-c): Remove build time bindgen dependency for sedona-geoarrow-c (#220)

Author: paleolimbot

Cargo.lock

@@ -27,7 +27,6 @@ edition.workspace = true
 rust-version.workspace = true
 
 [build-dependencies]
-bindgen = "0.71.0"
 cc = { version = "1" }
 
 [dev-dependencies]

c/sedona-geoarrow-c/Cargo.toml

@@ -14,7 +14,6 @@
 // KIND, either express or implied.  See the License for the
 // specific language governing permissions and limitations
 // under the License.
-use std::{env, path::PathBuf};
 
 fn main() {
     println!("cargo:rerun-if-changed=src/geoarrow/double_parse_fast_float.cc");
@@ -38,17 +37,4 @@ fn main() {
         .flag("-DGEOARROW_NAMESPACE=SedonaDB")
         .flag("-DNANOARROW_NAMESPACE=SedonaDB")
         .compile("geoarrow_fast_float");
-
-    let bindings = bindgen::Builder::default()
-        .header("src/geoarrow/geoarrow.h")
-        .clang_arg("-DGEOARROW_NAMESPACE=SedonaDB")
-        .parse_callbacks(Box::new(bindgen::CargoCallbacks::new()))
-        .generate()
-        .expect("Unable to generate bindings");
-
-    // Write the bindings to the $OUT_DIR/bindings.rs file.
-    let out_path = PathBuf::from(env::var("OUT_DIR").unwrap());
-    bindings
-        .write_to_file(out_path.join("bindings.rs"))
-        .expect("Couldn't write bindings!");
 }

c/sedona-geoarrow-c/build.rs

@@ -265,15 +265,6 @@ impl Default for Visitor {
     }
 }
 
-impl From<&str> for GeoArrowStringView {
-    fn from(value: &str) -> Self {
-        Self {
-            data: value.as_ptr() as *const _,
-            size_bytes: value.len() as i64,
-        }
-    }
-}
-
 /// Convert a [SedonaType] to a GeoArrow type identifier
 fn geoarrow_type_id(sedona_type: &SedonaType) -> Result<GeoArrowType, GeoArrowCError> {
     let type_id = match sedona_type {
@@ -414,10 +405,10 @@ mod test {
             DataType::Utf8View
         );
 
-        let err = arrow_storage_type(GeoArrowType_GEOARROW_TYPE_LINESTRING).unwrap_err();
+        let err = arrow_storage_type(0).unwrap_err();
         assert_eq!(
             err.to_string(),
-            "Can't guess Arrow type from GeoArrowType with ID 2"
+            "Can't guess Arrow type from GeoArrowType with ID 0"
         );
     }
 }

c/sedona-geoarrow-c/src/geoarrow_c.rs

@@ -17,6 +17,117 @@
 #![allow(non_upper_case_globals)]
 #![allow(non_camel_case_types)]
 #![allow(non_snake_case)]
-#![allow(dead_code)]
 
-include!(concat!(env!("OUT_DIR"), "/bindings.rs"));
+use std::os::raw::{c_char, c_int, c_void};
+
+#[repr(C)]
+pub struct ArrowArray {
+    _private: [u8; 0],
+}
+
+#[repr(C)]
+pub struct GeoArrowCoordView {
+    _private: [u8; 0],
+}
+
+#[cfg(target_env = "msvc")]
+pub type enum_t = std::os::raw::c_int;
+
+#[cfg(not(target_env = "msvc"))]
+pub type enum_t = std::os::raw::c_uint;
+
+pub type GeoArrowGeometryType = enum_t;
+pub type GeoArrowDimensions = enum_t;
+pub type GeoArrowType = enum_t;
+
+pub const GeoArrowType_GEOARROW_TYPE_WKB: GeoArrowType = 100001;
+pub const GeoArrowType_GEOARROW_TYPE_WKT: GeoArrowType = 100003;
+pub const GeoArrowType_GEOARROW_TYPE_WKB_VIEW: GeoArrowType = 100005;
+pub const GeoArrowType_GEOARROW_TYPE_WKT_VIEW: GeoArrowType = 100006;
+
+pub type GeoArrowErrorCode = c_int;
+
+#[repr(C)]
+#[derive(Debug, Copy, Clone)]
+pub struct GeoArrowError {
+    pub message: [c_char; 1024usize],
+}
+
+#[repr(C)]
+#[derive(Debug, Copy, Clone)]
+pub struct GeoArrowVisitor {
+    pub feat_start: Option<unsafe extern "C" fn(v: *mut GeoArrowVisitor) -> c_int>,
+    pub null_feat: Option<unsafe extern "C" fn(v: *mut GeoArrowVisitor) -> c_int>,
+    pub geom_start: Option<
+        unsafe extern "C" fn(
+            v: *mut GeoArrowVisitor,
+            geometry_type: GeoArrowGeometryType,
+            dimensions: GeoArrowDimensions,
+        ) -> c_int,
+    >,
+    pub ring_start: Option<unsafe extern "C" fn(v: *mut GeoArrowVisitor) -> c_int>,
+    pub coords: Option<
+        unsafe extern "C" fn(v: *mut GeoArrowVisitor, coords: *const GeoArrowCoordView) -> c_int,
+    >,
+    pub ring_end: Option<unsafe extern "C" fn(v: *mut GeoArrowVisitor) -> c_int>,
+    pub geom_end: Option<unsafe extern "C" fn(v: *mut GeoArrowVisitor) -> c_int>,
+    pub feat_end: Option<unsafe extern "C" fn(v: *mut GeoArrowVisitor) -> c_int>,
+    pub private_data: *mut c_void,
+    pub error: *mut GeoArrowError,
+}
+
+#[repr(C)]
+#[derive(Debug, Copy, Clone)]
+pub struct GeoArrowArrayReader {
+    pub private_data: *mut c_void,
+}
+
+#[repr(C)]
+#[derive(Debug, Copy, Clone)]
+pub struct GeoArrowArrayWriter {
+    pub private_data: *mut c_void,
+}
+
+unsafe extern "C" {
+    pub fn SedonaDBGeoArrowVersion() -> *const c_char;
+
+    pub fn SedonaDBGeoArrowVisitorInitVoid(v: *mut GeoArrowVisitor);
+
+    pub fn SedonaDBGeoArrowArrayReaderInitFromType(
+        reader: *mut GeoArrowArrayReader,
+        type_: GeoArrowType,
+    ) -> GeoArrowErrorCode;
+
+    pub fn SedonaDBGeoArrowArrayReaderSetArray(
+        reader: *mut GeoArrowArrayReader,
+        array: *const ArrowArray,
+        error: *mut GeoArrowError,
+    ) -> GeoArrowErrorCode;
+
+    pub fn SedonaDBGeoArrowArrayReaderVisit(
+        reader: *mut GeoArrowArrayReader,
+        offset: i64,
+        length: i64,
+        v: *mut GeoArrowVisitor,
+    ) -> GeoArrowErrorCode;
+
+    pub fn SedonaDBGeoArrowArrayReaderReset(reader: *mut GeoArrowArrayReader);
+
+    pub fn SedonaDBGeoArrowArrayWriterInitFromType(
+        writer: *mut GeoArrowArrayWriter,
+        type_: GeoArrowType,
+    ) -> GeoArrowErrorCode;
+
+    pub fn SedonaDBGeoArrowArrayWriterInitVisitor(
+        writer: *mut GeoArrowArrayWriter,
+        v: *mut GeoArrowVisitor,
+    ) -> GeoArrowErrorCode;
+
+    pub fn SedonaDBGeoArrowArrayWriterFinish(
+        writer: *mut GeoArrowArrayWriter,
+        array: *mut ArrowArray,
+        error: *mut GeoArrowError,
+    ) -> GeoArrowErrorCode;
+
+    pub fn SedonaDBGeoArrowArrayWriterReset(writer: *mut GeoArrowArrayWriter);
+}