Delete more unused code in geo-generic-alg, add more inlines to geo-traits-ext

Author: Kontinuation

rust/geo-generic-alg/src/algorithm/bounding_rect.rs

@@ -1,5 +1,5 @@
 use crate::utils::{partial_max, partial_min};
-use crate::{coord, geometry::*, CoordNum, GeometryCow};
+use crate::{coord, geometry::*, CoordNum};
 use core::borrow::Borrow;
 use geo_traits_ext::*;
 use geo_types::private_utils::get_bounding_rect;
@@ -252,17 +252,6 @@ where
     }
 }
 
-impl<T> BoundingRect<T> for GeometryCow<'_, T>
-where
-    T: CoordNum,
-{
-    type Output = Option<Rect<T>>;
-
-    crate::geometry_cow_delegate_impl! {
-       fn bounding_rect(&self) -> Self::Output;
-    }
-}
-
 // Return a new rectangle that encompasses the provided rectangles
 fn bounding_rect_merge<T: CoordNum>(a: Rect<T>, b: Rect<T>) -> Rect<T> {
     Rect::new(

rust/geo-generic-alg/src/algorithm/coordinate_position.rs

@@ -5,7 +5,7 @@ use crate::geometry::*;
 use crate::intersects::{point_in_rect, value_in_between};
 use crate::kernels::*;
 use crate::{BoundingRect, HasDimensions, Intersects};
-use crate::{GeoNum, GeometryCow};
+use crate::GeoNum;
 use geo_traits_ext::*;
 
 /// The position of a `Coord` relative to a `Geometry`
@@ -498,18 +498,6 @@ where
     }
 }
 
-impl<T: GeoNum> CoordinatePosition for GeometryCow<'_, T> {
-    type Scalar = T;
-
-    crate::geometry_cow_delegate_impl! {
-        fn calculate_coordinate_position(
-            &self,
-            coord: &Coord<T>,
-            is_inside: &mut bool,
-            boundary_count: &mut usize) -> ();
-    }
-}
-
 /// Calculate the position of a `Coord` relative to a
 /// closed `LineString`.
 pub fn coord_pos_relative_to_ring<T, LS>(coord: Coord<T>, linestring: &LS) -> CoordPos

rust/geo-generic-alg/src/algorithm/dimensions.rs

@@ -2,7 +2,7 @@ use core::borrow::Borrow;
 use geo_traits_ext::*;
 
 use crate::Orientation::Collinear;
-use crate::{CoordNum, GeoNum, GeometryCow};
+use crate::{CoordNum, GeoNum};
 
 /// Geometries can have 0, 1, or two dimensions. Or, in the case of an [`empty`](#is_empty)
 /// geometry, a special `Empty` dimensionality.
@@ -132,14 +132,6 @@ pub trait HasDimensions {
     fn boundary_dimensions(&self) -> Dimensions;
 }
 
-impl<C: GeoNum> HasDimensions for GeometryCow<'_, C> {
-    crate::geometry_cow_delegate_impl! {
-        fn is_empty(&self) -> bool;
-        fn dimensions(&self) -> Dimensions;
-        fn boundary_dimensions(&self) -> Dimensions;
-    }
-}
-
 impl<G> HasDimensions for G
 where
     G: GeoTraitExtWithTypeTag + HasDimensionsTrait<G::Tag>,

rust/geo-generic-alg/src/algorithm/kernels/mod.rs

@@ -1,5 +1,4 @@
 use num_traits::Zero;
-use std::cmp::Ordering;
 
 use crate::{coord, Coord, CoordNum};
 
@@ -10,18 +9,6 @@ pub enum Orientation {
     Collinear,
 }
 
-impl Orientation {
-    /// Helper to convert orientation-2d into an ordering.
-    #[inline]
-    pub(crate) fn as_ordering(&self) -> Ordering {
-        match self {
-            Orientation::CounterClockwise => Ordering::Less,
-            Orientation::Clockwise => Ordering::Greater,
-            Orientation::Collinear => Ordering::Equal,
-        }
-    }
-}
-
 /// Kernel trait to provide predicates to operate on
 /// different scalar types.
 pub trait Kernel<T: CoordNum> {

rust/geo-generic-alg/src/algorithm/line_measures/length.rs

@@ -1,5 +1,5 @@
 use super::Distance;
-use crate::{CoordFloat, Line, LineString, MultiLineString, Point};
+use crate::{CoordFloat, Point};
 use geo_traits::{CoordTrait, PolygonTrait};
 use geo_traits_ext::*;
 use std::borrow::Borrow;
@@ -359,6 +359,8 @@ mod tests {
 
     // Tests for LengthMeasurableExt - adapted from euclidean_length.rs
     mod length_measurable_ext_tests {
+        use geo::LineString;
+
         use super::*;
         use crate::{
             coord, line_string, polygon, Geometry, GeometryCollection, Line, MultiLineString,