-
Notifications
You must be signed in to change notification settings - Fork 30
[WIP] feat(c/sedona-libgpuspatial) Add GPU-accelerated spatial joins #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…/gpu-spatial-join
…/gpu-spatial-join
|
@pwrliang now the CI is working |
paleolimbot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing! It has been very cool to watch this project evolve over the last six months and I know this represents a huge amount of work.
This is a large change and I wanted to leave a few high-level things to think about while you're polishing this up.
- I see a bit of commented-out code in some of the files...feel free to file GitHub issues if that code represents a future piece of work that needs doing (and remove the commented-out code)!
- I see CUDA-specific tests, which are great! If there are portions of the code that aren't well-covered by tests we do need to add them (we can open follow-on issues and do this in follow-up PRs too)
- Because we're an Apache project we need the licensing and provenance of the files to be clear. I see some copyright notices from Nvidia...there's a place in LICENSE.md to acknowledge subdirectories where code was copied. We also need license headers on all the files (there's a script in scripts/ that can help do mass addition of the license header to a bunch of files at once).
- It looks like you've done a great job ensuring the casual contributor doesn't have to deal with the GPU build complexity using
default-members. That was one of my initial concerns but it looks great so far.
Give me a ping when you're ready for me to take a look!
@paleolimbot Hi, Dewey, thanks for your attention. Currently, this PR has resolved the license issues, and can pass almost all of the jobs in the CI. I'd like to hear any suggestions from you. @zhangfengcdt has written the Rust part to hook up sedona-db to libgpuspatial, so the credits for building go to him. |
|
@pwrliang Thanks for opening this PR! As per our discussion, we could break down this large PR into smaller ones to make it manageable and reviewable. Ideally, (1)libgpuspatial (c++ and cuda) with tests (2) gpu spatial join module in rust (3) build pipelines and e2e tests. Let me know if you can reduce this to only include (1) with the proper cleanup and apache license headers. We can continue (2) and (3) once this one merges. Thanks! |
This PR adds GPU-accelerated spatial join support to SedonaDB using NVIDIA CUDA and the libgpuspatial library. GPU execution is automatically enabled when available and provides significant performance improvements for large-scale spatial joins.
Core Features
GpuSpatialJoinExecphysical plan that leverages CUDA for parallel spatial join operations--features gpuTesting
test_gpu_spatial_join_sqlwith guaranteed-intersecting geometriesConfiguration
--features gpu(auto-enables when hardware detected)Testing