Skip to content

Commit 528d9ef

Browse files
committed
[SCB-1882]dependency update: spring data remove from DM and add version for provided
1 parent f82d447 commit 528d9ef

File tree

4 files changed

+13
-7
lines changed

4 files changed

+13
-7
lines changed

dependencies/default/pom.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@
102102
<spring.version>5.1.8.RELEASE</spring.version>
103103
<spring-boot.version>2.1.6.RELEASE</spring-boot.version>
104104
<spring-cloud.version>Greenwich.RELEASE</spring-cloud.version>
105-
<spring-data.version>2.0.9.RELEASE</spring-data.version>
106105
<stax2-api.version>4.2</stax2-api.version>
107106
<swagger.version>1.5.22</swagger.version>
108107
<swagger2markup.version>1.3.3</swagger2markup.version>
@@ -726,11 +725,6 @@
726725
<version>${jettison.version}</version>
727726
<scope>runtime</scope>
728727
</dependency>
729-
<dependency>
730-
<groupId>org.springframework.data</groupId>
731-
<artifactId>spring-data-commons</artifactId>
732-
<version>${spring-data.version}</version>
733-
</dependency>
734728

735729
<dependency>
736730
<groupId>org.codehaus.woodstox</groupId>

swagger/swagger-generator/generator-spring-data/pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@
4040
<!-- based on business project dependency -->
4141
<optional>true</optional>
4242
<scope>provided</scope>
43+
<!-- This is provided scope, better not add to dependency management, so add version here -->
44+
<version>2.1.9.RELEASE</version>
4345
</dependency>
4446

4547
</dependencies>

swagger/swagger-generator/generator-spring-data/src/test/java/org/apache/servicecomb/swagger/generator/springdata/TestPageResponseTypeProcessor.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,11 @@ public void deserialize() throws IOException {
4343
Page<?> page = Json.mapper().readValue(json, Page.class);
4444

4545
Assert.assertEquals(
46-
"{\"content\":[\"c1\",\"c2\"],\"pageable\":{\"offset\":2,\"pageNumber\":1,\"pageSize\":2,\"paged\":true,\"sort\":{\"sorted\":false,\"unsorted\":true},\"unpaged\":false},\"first\":false,\"last\":true,\"number\":1,\"numberOfElements\":2,\"size\":2,\"sort\":{\"sorted\":false,\"unsorted\":true},\"totalElements\":4,\"totalPages\":2}",
46+
"{\"content\":[\"c1\",\"c2\"],\"pageable\":{\"offset\":2,\"pageNumber\":1,\"pageSize\":2,"
47+
+ "\"paged\":true,\"sort\":{\"empty\":true,\"sorted\":false,\"unsorted\":true},"
48+
+ "\"unpaged\":false},\"empty\":false,\"first\":false,\"last\":true,\"number\":1,"
49+
+ "\"numberOfElements\":2,\"size\":2,\"sort\":{\"empty\":true,\"sorted\":false,"
50+
+ "\"unsorted\":true},\"totalElements\":4,\"totalPages\":2}",
4751
Json.mapper().writeValueAsString(page));
4852
}
4953
}

swagger/swagger-generator/generator-spring-data/src/test/resources/pageSchema.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@ definitions:
4949
type: "array"
5050
items:
5151
type: "object"
52+
empty:
53+
type: "boolean"
5254
first:
5355
type: "boolean"
5456
last:
@@ -80,6 +82,8 @@ definitions:
8082
type: "array"
8183
items:
8284
type: "string"
85+
empty:
86+
type: "boolean"
8387
first:
8488
type: "boolean"
8589
last:
@@ -126,6 +130,8 @@ definitions:
126130
Sort:
127131
type: "object"
128132
properties:
133+
empty:
134+
type: "boolean"
129135
sorted:
130136
type: "boolean"
131137
unsorted:

0 commit comments

Comments
 (0)