Skip to content

Commit dfb4dbd

Browse files
refactor(loadbalance): Modify load balancing configuration and naming
- Fix typos in Configuration file -Rename RuleNameExtentionsFactory to RuleNameExtensionsFactory - Update references in relevant test files - Added Verticle as an allowed word in .typos.toml - Fixed typo in AbstractArgumentsMapperCreator file - Fixed typo in FaultInjectionUtil file
1 parent 30fadd5 commit dfb4dbd

File tree

8 files changed

+12
-8
lines changed

8 files changed

+12
-8
lines changed

.typos.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,8 @@
2626
[files]
2727
ignore = [
2828
"**/cobertura.ser"
29+
]
30+
[words]
31+
allow = [
32+
"Verticle",
2933
]

handlers/handler-fault-injection/src/main/java/org/apache/servicecomb/faultinjection/FaultInjectionUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public class FaultInjectionUtil {
3939
private FaultInjectionUtil() {
4040
}
4141

42-
// key is config paramter
42+
// key is config parameter
4343
private static final Map<String, AtomicInteger> configCenterValue = new ConcurrentHashMapEx<>();
4444

4545
/**

handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/Configuration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public final class Configuration {
3838
// 2.0 configuration items
3939
public static final String ROOT_20 = "ribbon.";
4040

41-
// SessionStickinessRule configruation
41+
// SessionStickinessRule configuration
4242
public static final String SESSION_TIMEOUT_IN_SECONDS = "SessionStickinessRule.sessionTimeoutInSeconds";
4343

4444
public static final String SUCCESSIVE_FAILED_TIMES = "SessionStickinessRule.successiveFailedTimes";

handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadBalanceConfiguration.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ public LoadBalanceFilter scbLoadBalanceFilter(ExtensionsManager extensionsManage
4343
}
4444

4545
@Bean
46-
public RuleNameExtentionsFactory scbRuleNameExtentionsFactory() {
47-
return new RuleNameExtentionsFactory();
46+
public RuleNameExtensionsFactory scbRuleNameExtensionsFactory() {
47+
return new RuleNameExtensionsFactory();
4848
}
4949

5050
@Bean

handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/RuleNameExtentionsFactory.java renamed to handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/RuleNameExtensionsFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
import com.google.common.collect.Lists;
2222

23-
public class RuleNameExtentionsFactory implements ExtensionsFactory {
23+
public class RuleNameExtensionsFactory implements ExtensionsFactory {
2424
private static final Collection<String> ACCEPT_KEYS = Lists.newArrayList(
2525
Configuration.RULE_STRATEGY_NAME);
2626

handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestExtensionsManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public void tearDown() {
4242
@Test
4343
public void testRuleName() {
4444
List<ExtensionsFactory> extensionsFactories = new ArrayList<>();
45-
extensionsFactories.add(new RuleNameExtentionsFactory());
45+
extensionsFactories.add(new RuleNameExtensionsFactory());
4646
ExtensionsManager extensionsManager = new ExtensionsManager(extensionsFactories);
4747

4848
Assertions.assertEquals(RoundRobinRuleExt.class.getName(),

handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestLoadBalanceFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ Transport findTransport(String transportName) {
114114
};
115115

116116
List<ExtensionsFactory> extensionsFactories = new ArrayList<>();
117-
extensionsFactories.add(new RuleNameExtentionsFactory());
117+
extensionsFactories.add(new RuleNameExtensionsFactory());
118118
ExtensionsManager extensionsManager = new ExtensionsManager(extensionsFactories);
119119

120120
DiscoveryTree discoveryTree = new DiscoveryTree(

swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/arguments/AbstractArgumentsMapperCreator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
* int add(int x, int y)
5858
* swagger parameters:
5959
* x, y
60-
* 2) swagger only one POJO paramter, extract all field to method parameters (POJO dev mode)
60+
* 2) swagger only one POJO parameter, extract all field to method parameters (POJO dev mode)
6161
* interface method:
6262
* int add(int x, int y)
6363
* swagger parameters:

0 commit comments

Comments
 (0)