Skip to content

Commit fb4ccaa

Browse files
committed
[SCB-2842]change default setting for connection timeout and zone-aware ratio
1 parent 43aa274 commit fb4ccaa

File tree

4 files changed

+10
-9
lines changed

4 files changed

+10
-9
lines changed

foundations/foundation-registry/src/main/java/org/apache/servicecomb/registry/consumer/MicroserviceVersions.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -234,20 +234,20 @@ private void setInstances(List<MicroserviceInstance> pulledInstances, String rev
234234
MergedInstances mergedInstances = mergeInstances(pulledInstances, instances);
235235
instances = mergedInstances.instanceIdMap.values();
236236

237-
// set instances to empty for no instance versions
238-
versions.forEach((key, value) -> {
239-
if (!mergedInstances.microserviceIdMap.containsKey(key)) {
240-
value.setInstances(new ArrayList<>());
241-
}
242-
});
243-
244237
// update instances
245238
for (Entry<String, List<MicroserviceInstance>> entry : mergedInstances.microserviceIdMap.entrySet()) {
246239
versions.computeIfAbsent(entry.getKey(),
247240
microserviceId -> createMicroserviceVersion(microserviceId, entry.getValue()))
248241
.setInstances(entry.getValue());
249242
}
250243

244+
// set instances to empty for no instance versions
245+
versions.forEach((key, value) -> {
246+
if (!mergedInstances.microserviceIdMap.containsKey(key)) {
247+
value.setInstances(new ArrayList<>());
248+
}
249+
});
250+
251251
for (MicroserviceVersionRule microserviceVersionRule : versionRules.values()) {
252252
microserviceVersionRule.update(versions, instances);
253253
}

handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/filterext/ZoneAwareDiscoveryFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public boolean enabled() {
4545

4646
private int getRatio() {
4747
return DynamicPropertyFactory.getInstance()
48-
.getIntProperty(CONFIG_RATIO, 50).get();
48+
.getIntProperty(CONFIG_RATIO, 30).get();
4949
}
5050

5151
@Override

handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/filterext/TestZoneAwareDiscoveryFilter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ public void tearDown() {
4949

5050
@Test
5151
public void test_not_enough_instance() {
52+
ArchaiusUtils.setProperty(ZoneAwareDiscoveryFilter.CONFIG_RATIO, 50);
5253
ZoneAwareDiscoveryFilter filter = new ZoneAwareDiscoveryFilter();
5354

5455
// set up data

transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/TransportClientConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ public static boolean isHttpTransportClientEnabled() {
139139

140140
public static int getConnectionTimeoutInMillis() {
141141
return DynamicPropertyFactory.getInstance()
142-
.getIntProperty("servicecomb.rest.client.connection.timeoutInMillis", 1000)
142+
.getIntProperty("servicecomb.rest.client.connection.timeoutInMillis", 60000)
143143
.get();
144144
}
145145
}

0 commit comments

Comments
 (0)