Skip to content

Commit 8d53b9e

Browse files
authored
Fix validateJobProperties (#1684)
1 parent 223374b commit 8d53b9e

File tree

1 file changed

+5
-5
lines changed
  • elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/schedule

1 file changed

+5
-5
lines changed

elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/schedule/JobScheduler.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,10 @@ public JobScheduler(final CoordinatorRegistryCenter regCenter, final ElasticJob
8282
setUpFacade = new SetUpFacade(regCenter, jobConfig.getJobName(), jobListeners);
8383
schedulerFacade = new SchedulerFacade(regCenter, jobConfig.getJobName());
8484
jobFacade = new LiteJobFacade(regCenter, jobConfig.getJobName(), jobListeners, findTracingConfiguration(jobConfig).orElse(null));
85+
validateJobProperties(jobConfig);
8586
jobExecutor = new ElasticJobExecutor(elasticJob, jobConfig, jobFacade);
8687
String jobClassName = JobClassNameProviderFactory.getProvider().getJobClassName(elasticJob);
8788
this.jobConfig = setUpFacade.setUpJobConfiguration(jobClassName, jobConfig);
88-
validateJobProperties();
8989
setGuaranteeServiceForElasticJobListeners(regCenter, jobListeners);
9090
jobScheduleController = createJobScheduleController();
9191
}
@@ -97,9 +97,9 @@ public JobScheduler(final CoordinatorRegistryCenter regCenter, final String elas
9797
setUpFacade = new SetUpFacade(regCenter, jobConfig.getJobName(), jobListeners);
9898
schedulerFacade = new SchedulerFacade(regCenter, jobConfig.getJobName());
9999
jobFacade = new LiteJobFacade(regCenter, jobConfig.getJobName(), jobListeners, findTracingConfiguration(jobConfig).orElse(null));
100+
validateJobProperties(jobConfig);
100101
jobExecutor = new ElasticJobExecutor(elasticJobType, jobConfig, jobFacade);
101102
this.jobConfig = setUpFacade.setUpJobConfiguration(elasticJobType, jobConfig);
102-
validateJobProperties();
103103
setGuaranteeServiceForElasticJobListeners(regCenter, jobListeners);
104104
jobScheduleController = createJobScheduleController();
105105
}
@@ -114,11 +114,11 @@ private Optional<TracingConfiguration<?>> findTracingConfiguration(final JobConf
114114
return jobConfig.getExtraConfigurations().stream().filter(each -> each instanceof TracingConfiguration).findFirst().map(extraConfig -> (TracingConfiguration<?>) extraConfig);
115115
}
116116

117-
private void validateJobProperties() {
118-
validateJobErrorHandlerProperties();
117+
private void validateJobProperties(final JobConfiguration jobConfig) {
118+
validateJobErrorHandlerProperties(jobConfig);
119119
}
120120

121-
private void validateJobErrorHandlerProperties() {
121+
private void validateJobErrorHandlerProperties(final JobConfiguration jobConfig) {
122122
if (null != jobConfig.getJobErrorHandlerType()) {
123123
ElasticJobServiceLoader.newTypedServiceInstance(JobErrorHandlerPropertiesValidator.class, jobConfig.getJobErrorHandlerType(), jobConfig.getProps())
124124
.ifPresent(validator -> validator.validate(jobConfig.getProps()));

0 commit comments

Comments
 (0)