Skip to content

Commit 91bdac4

Browse files
authored
Merge branch 'master' into fix-order-dependent-test-Resilience4JPluginTest
2 parents f3cfe20 + dcdd727 commit 91bdac4

File tree

137 files changed

+3421
-2954
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

137 files changed

+3421
-2954
lines changed

script/shenyu_checkstyle.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@
211211
<module name="SimplifyBooleanExpression"/>
212212
<module name="SimplifyBooleanReturn"/>
213213
<module name="StringLiteralEquality"/>
214-
<module name="UnnecessaryParentheses"/>
214+
<!-- <module name="UnnecessaryParentheses"/>-->
215215
<module name="VariableDeclarationUsageDistance"/>
216216
<!--Checks that classes that override equals() also override hashCode()-->
217217
<module name="EqualsHashCode"/>

shenyu-admin-listener/shenyu-admin-listener-zookeeper/pom.xml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,9 @@
3535
</dependency>
3636

3737
<dependency>
38-
<groupId>org.apache.curator</groupId>
39-
<artifactId>curator-framework</artifactId>
40-
</dependency>
41-
42-
<dependency>
43-
<groupId>org.apache.curator</groupId>
44-
<artifactId>curator-recipes</artifactId>
38+
<groupId>org.apache.shenyu</groupId>
39+
<artifactId>shenyu-infra-zookeeper</artifactId>
40+
<version>${project.version}</version>
4541
</dependency>
4642

4743
<dependency>

shenyu-admin-listener/shenyu-admin-listener-zookeeper/src/main/java/org/apache/shenyu/admin/config/ZookeeperSyncConfiguration.java

Lines changed: 21 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,18 @@
1717

1818
package org.apache.shenyu.admin.config;
1919

20-
import org.apache.shenyu.admin.config.properties.ZookeeperConfig;
21-
import org.apache.shenyu.admin.config.properties.ZookeeperProperties;
2220
import org.apache.shenyu.admin.listener.DataChangedInit;
2321
import org.apache.shenyu.admin.listener.DataChangedListener;
24-
import org.apache.shenyu.admin.listener.zookeeper.ZookeeperClient;
2522
import org.apache.shenyu.admin.listener.zookeeper.ZookeeperDataChangedInit;
2623
import org.apache.shenyu.admin.listener.zookeeper.ZookeeperDataChangedListener;
24+
import org.apache.shenyu.infra.zookeeper.autoconfig.ZookeeperConfiguration;
25+
import org.apache.shenyu.infra.zookeeper.autoconfig.ZookeeperProperties;
26+
import org.apache.shenyu.infra.zookeeper.autoconfig.ConditionOnSyncZookeeper;
27+
import org.apache.shenyu.infra.zookeeper.client.ZookeeperClient;
28+
import org.apache.shenyu.infra.zookeeper.config.ZookeeperConfig;
29+
import org.springframework.boot.autoconfigure.AutoConfiguration;
30+
import org.springframework.boot.autoconfigure.ImportAutoConfiguration;
2731
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
28-
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
29-
import org.springframework.boot.context.properties.EnableConfigurationProperties;
3032
import org.springframework.context.annotation.Bean;
3133
import org.springframework.context.annotation.Configuration;
3234

@@ -35,9 +37,11 @@
3537
/**
3638
* The type Zookeeper listener.
3739
*/
40+
3841
@Configuration
39-
@ConditionalOnProperty(prefix = "shenyu.sync.zookeeper", name = "url")
40-
@EnableConfigurationProperties(ZookeeperProperties.class)
42+
@ConditionOnSyncZookeeper
43+
@AutoConfiguration(after = {ZookeeperConfiguration.class})
44+
@ImportAutoConfiguration(ZookeeperConfiguration.class)
4145
public class ZookeeperSyncConfiguration {
4246

4347
/**
@@ -49,14 +53,16 @@ public class ZookeeperSyncConfiguration {
4953
@Bean
5054
@ConditionalOnMissingBean(ZookeeperClient.class)
5155
public ZookeeperClient zookeeperClient(final ZookeeperProperties zookeeperProp) {
52-
int sessionTimeout = Objects.isNull(zookeeperProp.getSessionTimeout()) ? 3000 : zookeeperProp.getSessionTimeout();
53-
int connectionTimeout = Objects.isNull(zookeeperProp.getConnectionTimeout()) ? 3000 : zookeeperProp.getConnectionTimeout();
54-
ZookeeperConfig zkConfig = new ZookeeperConfig(zookeeperProp.getUrl());
55-
zkConfig.setSessionTimeoutMilliseconds(sessionTimeout)
56-
.setConnectionTimeoutMilliseconds(connectionTimeout);
57-
ZookeeperClient client = new ZookeeperClient(zkConfig);
58-
client.start();
59-
return client;
56+
57+
int sessionTimeout = Objects.isNull(zookeeperProp.getZookeeper().getSessionTimeoutMilliseconds()) ? 3000 : zookeeperProp.getZookeeper().getSessionTimeoutMilliseconds();
58+
int connectionTimeout = Objects.isNull(zookeeperProp.getZookeeper().getConnectionTimeoutMilliseconds()) ? 3000 : zookeeperProp.getZookeeper().getConnectionTimeoutMilliseconds();
59+
60+
ZookeeperConfig zkConfig = ZookeeperConfig.builder()
61+
.url(zookeeperProp.getZookeeper().getUrl())
62+
.sessionTimeoutMilliseconds(sessionTimeout)
63+
.connectionTimeoutMilliseconds(connectionTimeout)
64+
.build();
65+
return new ZookeeperClient(zkConfig);
6066
}
6167

6268
/**

shenyu-admin-listener/shenyu-admin-listener-zookeeper/src/main/java/org/apache/shenyu/admin/config/properties/ZookeeperConfig.java

Lines changed: 0 additions & 199 deletions
This file was deleted.

shenyu-admin-listener/shenyu-admin-listener-zookeeper/src/main/java/org/apache/shenyu/admin/config/properties/ZookeeperProperties.java

Lines changed: 0 additions & 87 deletions
This file was deleted.

0 commit comments

Comments
 (0)