Skip to content

Commit 7c38bab

Browse files
authored
Make TraceQueryResponse internal trace return object. (#100)
1 parent 2beb0e4 commit 7c38bab

File tree

3 files changed

+10
-13
lines changed

3 files changed

+10
-13
lines changed

.licenserc.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ dependency:
5656
version: 9999.0-empty-to-avoid-conflict-with-guava
5757
license: Apache-2.0
5858
- name: build.buf.protoc-gen-validate:pgv-java-stub
59-
version: 0.6.13
59+
version: 1.2.1
6060
license: Apache-2.0
6161
- name: build.buf.protoc-gen-validate:protoc-gen-validate
62-
version: 0.6.13
62+
version: 1.2.1
6363
license: Apache-2.0

dist-material/LICENSE

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -178,8 +178,8 @@
178178
Apache-2.0 licenses
179179
========================================================================
180180

181-
build.buf.protoc-gen-validate:pgv-java-stub 0.6.13 Apache-2.0
182-
build.buf.protoc-gen-validate:protoc-gen-validate 0.6.13 Apache-2.0
181+
build.buf.protoc-gen-validate:pgv-java-stub 1.2.1 Apache-2.0
182+
build.buf.protoc-gen-validate:protoc-gen-validate 1.2.1 Apache-2.0
183183
com.google.android:annotations 4.1.1.4 Apache-2.0
184184
com.google.api.grpc:proto-google-common-protos 2.0.1 Apache-2.0
185185
com.google.code.findbugs:jsr305 3.0.2 Apache-2.0
@@ -189,7 +189,7 @@ Apache-2.0 licenses
189189
com.google.guava:guava 31.0.1-android Apache-2.0
190190
com.google.guava:listenablefuture 9999.0-empty-to-avoid-conflict-with-guava Apache-2.0
191191
com.google.j2objc:j2objc-annotations 1.3 Apache-2.0
192-
commons-validator:commons-validator 1.7 Apache-2.0
192+
commons-validator:commons-validator 1.9 Apache-2.0
193193
io.grpc:grpc-api 1.46.0 Apache-2.0
194194
io.grpc:grpc-context 1.46.0 Apache-2.0
195195
io.grpc:grpc-core 1.46.0 Apache-2.0
@@ -236,4 +236,4 @@ MIT licenses
236236
https://golang.org/LICENSE licenses
237237
========================================================================
238238

239-
com.google.re2j:re2j 1.5 https://golang.org/LICENSE
239+
com.google.re2j:re2j 1.7 https://golang.org/LICENSE

src/main/java/org/apache/skywalking/banyandb/v1/client/TraceQueryResponse.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,11 @@
2727
*/
2828
public class TraceQueryResponse {
2929
private final BanyandbTrace.QueryResponse response;
30+
private final Trace trace;
3031

3132
TraceQueryResponse(BanyandbTrace.QueryResponse response) {
3233
this.response = response;
34+
this.trace = Trace.convertFromProto(response.getTraceQueryResult());
3335
}
3436

3537
/**
@@ -43,14 +45,9 @@ public List<BanyandbTrace.Trace> getTraces() {
4345

4446
/**
4547
* Get the trace query execution trace if enabled.
46-
*
47-
* @return trace query execution trace or null if not enabled
4848
*/
49-
public String getTraceResult() {
50-
if (response.hasTraceQueryResult()) {
51-
return response.getTraceQueryResult().toString();
52-
}
53-
return null;
49+
public Trace getTraceResult() {
50+
return this.trace;
5451
}
5552

5653
/**

0 commit comments

Comments
 (0)