|
| 1 | +<!-- |
| 2 | + ⚠️ Please make sure to read this template first, pull requests that don't accord with this template |
| 3 | + maybe closed without notice. |
| 4 | + Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>. |
| 5 | + Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` |
| 6 | +--> |
| 7 | + |
| 8 | +<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ==== |
| 9 | +### Fix <bug description or bug issue link> |
| 10 | +- [ ] Add a unit test to verify that the fix works. |
| 11 | +- [ ] Explain briefly why the bug exists and how to fix it. |
| 12 | + ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== --> |
| 13 | + |
| 14 | +<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ==== |
| 15 | +### Improve the performance of <class or module or ...> |
| 16 | +- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/oap-server/microbench/src/main/java/org/apache/skywalking/oap/server/microbench/library/datacarrier/LinkedArrayBenchmark.java) |
| 17 | +- [ ] The benchmark result. |
| 18 | +```text |
| 19 | +<Paste the benchmark results here> |
| 20 | +``` |
| 21 | +- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here> |
| 22 | + ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== --> |
| 23 | + |
| 24 | +<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ==== |
| 25 | +### <Feature description> |
| 26 | +- [ ] If this is non-trivial feature, paste the links/URLs to the design doc. |
| 27 | +- [ ] Update the documentation to include this new feature. |
| 28 | +- [ ] Tests(including UT, IT, E2E) are added to verify the new feature. |
| 29 | +- [ ] If it's UI related, attach the screenshots below. |
| 30 | +- [ ] I have rebuilt the `Configuration.md` documentation by running `make doc-gen` |
| 31 | + ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== --> |
| 32 | + |
| 33 | +<!-- ==== 📱 Remove this line WHEN AND ONLY WHEN you're adding or modifying a plugin instrumentation, follow the checklist 👇 ==== |
| 34 | +### <Feature description> |
| 35 | +- [ ] If adding a new plugin, add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml) |
| 36 | +- [ ] If adding a new plugin, add a logo in [the UI repo](https://github.com/apache/skywalking-booster-ui/tree/main/src/assets/img/technologies) |
| 37 | +- [ ] I have added the library to `pyproject.toml` (plugin group) by running `poetry add library --group plugins` |
| 38 | +- [ ] I have rebuilt the `Plugins.md` documentation by running `make doc-gen` |
| 39 | + ==== 📱 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== --> |
| 40 | + |
| 41 | +- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue url. Closes: <URL to main repo issue> |
| 42 | +- [ ] Update the [`CHANGELOG.md`](https://github.com/apache/skywalking-ruby/blob/main/CHANGELOG.md). |
0 commit comments