Fix missing memory filter when query profiling trace. (#13534)

Author: wankai123

oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/trace/BanyanDBTraceQueryDAO.java

@@ -79,6 +79,9 @@ public List<SegmentRecord> queryByTraceId(String traceId, @Nullable Duration dur
 
     @Override
     public List<SegmentRecord> queryBySegmentIdList(List<String> segmentIdList, @Nullable Duration duration) throws IOException {
+        if (CollectionUtils.isEmpty(segmentIdList)) {
+            return Collections.emptyList();
+        }
         final boolean isColdStage = duration != null && duration.isColdStage();
         TraceQueryResponse resp = queryTraceDebuggable(isColdStage, SegmentRecord.INDEX_NAME, getTimestampRange(duration),
             new QueryBuilder<TraceQuery>() {
@@ -89,11 +92,14 @@ public void apply(TraceQuery query) {
                     query.setOrderBy(new TraceQuery.OrderBy(SegmentRecord.START_TIME, AbstractQuery.Sort.DESC));
                 }
             });
-        return buildRecords(resp);
+        return buildRecords(resp, segmentIdList, null, true);
     }
 
     @Override
     public List<SegmentRecord> queryByTraceIdWithInstanceId(List<String> traceIdList, List<String> instanceIdList, @Nullable Duration duration) throws IOException {
+        if (CollectionUtils.isEmpty(traceIdList) || CollectionUtils.isEmpty(instanceIdList)) {
+            return Collections.emptyList();
+        }
         final boolean isColdStage = duration != null && duration.isColdStage();
         TraceQueryResponse resp = queryTraceDebuggable(isColdStage, SegmentRecord.INDEX_NAME, getTimestampRange(duration),
                                          new QueryBuilder<TraceQuery>() {
@@ -105,7 +111,7 @@ public void apply(TraceQuery query) {
                                              }
                                          });
 
-        return buildRecords(resp);
+        return buildRecords(resp, null, instanceIdList, false);
     }
 
     @Override
@@ -226,14 +232,22 @@ public void apply(TraceQuery query) {
     /**
      * Notice: this method not build the full SegmentRecord, only build the fields needed by ProfiledTraceSegments and ProfiledSegment
      */
-    private List<SegmentRecord> buildRecords(TraceQueryResponse resp) throws IOException {
+    private List<SegmentRecord> buildRecords(TraceQueryResponse resp,
+                                             @Nullable List<String> segmentIdList,
+                                             @Nullable List<String> instanceIdList,
+                                             boolean filterBySegmentId) throws IOException {
         List<SegmentRecord> segmentRecords = new ArrayList<>();
         for (var t : resp.getTraces()) {
             for (var wrapper : t.getSpansList()) {
                 SpanWrapper spanWrapper = SpanWrapper.parseFrom(wrapper.getSpan());
                 if (spanWrapper.getSource().equals(Source.SKYWALKING)) {
                     SegmentObject segmentObject = SegmentObject.parseFrom(spanWrapper.getSpan());
                     SegmentRecord segmentRecord = new SegmentRecord();
+                    if (filterBySegmentId) {
+                        if (segmentIdList == null || !segmentIdList.contains(segmentObject.getTraceSegmentId())) {
+                            continue;
+                        }
+                    }
                     segmentRecord.setSegmentId(segmentObject.getTraceSegmentId());
                     segmentRecord.setTraceId(segmentObject.getTraceId());
                     String serviceName = Const.EMPTY_STRING;
@@ -244,6 +258,11 @@ private List<SegmentRecord> buildRecords(TraceQueryResponse resp) throws IOExcep
                     String serviceId = IDManager.ServiceID.buildId(serviceName, true);
                     segmentRecord.setServiceId(serviceId);
                     String serviceInstanceId = IDManager.ServiceInstanceID.buildId(serviceId, instanceName);
+                    if (!filterBySegmentId) {
+                        if (instanceIdList == null || !instanceIdList.contains(serviceInstanceId)) {
+                            continue;
+                        }
+                    }
                     segmentRecord.setServiceInstanceId(serviceInstanceId);
                     long startTimestamp = 0;
                     long endTimestamp = 0;