Skip to content

Commit dc52318

Browse files
committed
Fix BrowserWebVitalsPerfData clsTime to cls and make it double type.
1 parent 9dffe13 commit dc52318

File tree

6 files changed

+9
-6
lines changed

6 files changed

+9
-6
lines changed

docs/en/api/browser-protocol.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ Input:
5555
"pagePath": "/index.html",
5656
"fmpTime": 10, // Deprecated since skywalking-client-js 1.0. This is no longer recommended. Please use the `useWebVitals` instead.
5757
/* NOTE, Safari does not support all core web vitals, and Firefox does not support `CLS`. */
58-
"clsTime": 10,
58+
"clsTime": 0.1,
5959
"lcpTime": 10,
6060
}
6161
```

docs/en/changes/changes.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
* KubernetesCoordinator: make self instance return real pod IP address instead of `127.0.0.1`.
88
* Enhance the alarm kernel with recovered status notification capability
9+
* Fix BrowserWebVitalsPerfData `clsTime` to `cls` and make it double type.
910

1011
#### UI
1112
* Fix the missing icon in new native trace view.

oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/browser/source/BrowserAppWebVitalsPerf.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public String getEntityId() {
5050
private String serviceName;
5151
private String path;
5252
private int fmpTime;
53-
private int clsTime;
53+
private int cls;
5454
private int lcpTime;
5555

5656
@Override

oap-server/server-receiver-plugin/skywalking-browser-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/browser/provider/parser/performance/decorators/BrowserWebVitalsPerfDataDecorator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public int getLcpTime() {
6969
return builder.getLcpTime();
7070
}
7171

72-
public int getClsTime() {
73-
return builder.getClsTime();
72+
public double getCls() {
73+
return builder.getCls();
7474
}
7575
}

oap-server/server-receiver-plugin/skywalking-browser-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/browser/provider/parser/performance/listener/BrowserWebVitalsPerfDataAnalysisListener.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,9 @@ public void parse(BrowserWebVitalsPerfDataDecorator decorator) {
4949
browserAppWebVitalsPerf.setServiceName(namingControl.formatServiceName(decorator.getService()));
5050
browserAppWebVitalsPerf.setPath(namingControl.formatEndpointName(browserAppWebVitalsPerf.getServiceName(), decorator.getPagePath()));
5151
browserAppWebVitalsPerf.setFmpTime(decorator.getFmpTime());
52-
browserAppWebVitalsPerf.setClsTime(decorator.getClsTime());
52+
// Make CLS multiply 1000 to convert to int from double
53+
// MQE should divide it by 1000 while querying
54+
browserAppWebVitalsPerf.setCls((int) Math.round(decorator.getCls() * 1000));
5355
browserAppWebVitalsPerf.setLcpTime(decorator.getLcpTime());
5456
}
5557

0 commit comments

Comments
 (0)