Skip to content

Commit 4af06a9

Browse files
authored
minor: AuthorizationFailure is now a record (#4198)
1 parent 684894a commit 4af06a9

File tree

3 files changed

+3
-19
lines changed

3 files changed

+3
-19
lines changed

solr/core/src/java/org/apache/solr/jersey/SolrRequestAuthorizer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ public void filter(ContainerRequestContext requestContext) throws IOException {
8989
AuthorizationUtils.authorize(servletRequest, servletResponse, coreContainer, authzContext);
9090
if (authzFailure != null) {
9191
final Response failureResponse =
92-
Response.status(authzFailure.getStatusCode()).entity(authzFailure.getMessage()).build();
92+
Response.status(authzFailure.statusCode()).entity(authzFailure.message()).build();
9393
requestContext.abortWith(failureResponse);
9494
}
9595
}

solr/core/src/java/org/apache/solr/security/AuthorizationUtils.java

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -43,23 +43,7 @@ private AuthorizationUtils() {
4343
/* Private ctor prevents instantiation */
4444
}
4545

46-
public static class AuthorizationFailure {
47-
private final int statusCode;
48-
private final String message;
49-
50-
public AuthorizationFailure(int statusCode, String message) {
51-
this.statusCode = statusCode;
52-
this.message = message;
53-
}
54-
55-
public int getStatusCode() {
56-
return statusCode;
57-
}
58-
59-
public String getMessage() {
60-
return message;
61-
}
62-
}
46+
public record AuthorizationFailure(int statusCode, String message) {}
6347

6448
public static AuthorizationFailure authorize(
6549
HttpServletRequest servletReq,

solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,7 @@ && shouldAuthorize()
450450
AuthorizationUtils.AuthorizationFailure authzFailure =
451451
AuthorizationUtils.authorize(req, response, cores, authzContext);
452452
if (authzFailure != null) {
453-
sendError(authzFailure.getStatusCode(), authzFailure.getMessage());
453+
sendError(authzFailure.statusCode(), authzFailure.message());
454454
return RETURN;
455455
}
456456
}

0 commit comments

Comments
 (0)