Skip to content

Commit 6117799

Browse files
committed
SOLR-17458: Metrics: Switch to OTEL from Dropwizard
Merging feature/SOLR-17458-rebased
2 parents 2aa21a1 + 1abd6aa commit 6117799

File tree

425 files changed

+9365
-35362
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

425 files changed

+9365
-35362
lines changed

.github/labeler.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -98,12 +98,6 @@ admin-ui:
9898
- solr/webapp/**
9999
- solr/ui/**
100100

101-
# Add 'prometheus-exporter' label
102-
prometheus-exporter:
103-
- changed-files:
104-
- any-glob-to-any-file:
105-
- solr/prometheus-exporter/**
106-
107101
# Add labels for changes to solr modules
108102
module:analysis-extras:
109103
- changed-files:

.github/workflows/bin-solr-test.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ on:
99
- 'solr/bin/**'
1010
- 'solr/packaging/**'
1111
- 'solr/core/src/java/org/apache/solr/cli/**'
12-
- 'solr/prometheus-exporter/**'
1312

1413
jobs:
1514
test:

.github/workflows/docker-test.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ on:
77
paths:
88
- '.github/workflows/docker-test.yml'
99
- 'solr/bin/**'
10-
- 'solr/prometheus-exporter/bin/**'
1110
- 'solr/docker/**'
1211
- 'solr/packaging/**'
1312

dev-tools/scripts/smokeTestRelease.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -636,7 +636,7 @@ def verifyUnpacked(java, artifact, unpackPath, gitRevision, version, testArgs):
636636
expected_src_root_folders = ['build-tools', 'dev-docs', 'dev-tools', 'gradle', 'help', 'solr']
637637
expected_src_root_files = ['build.gradle', 'gradlew', 'gradlew.bat', 'settings.gradle', 'settings-gradle.lockfile', 'versions.lock']
638638
expected_src_solr_files = ['build.gradle']
639-
expected_src_solr_folders = ['benchmark', 'bin', 'modules', 'api', 'core', 'cross-dc-manager', 'docker', 'documentation', 'example', 'licenses', 'packaging', 'distribution', 'prometheus-exporter', 'server', 'solr-ref-guide', 'solrj', 'solrj-streaming', 'solrj-zookeeper', 'test-framework', 'webapp', '.gitignore', '.gitattributes']
639+
expected_src_solr_folders = ['benchmark', 'bin', 'modules', 'api', 'core', 'cross-dc-manager', 'docker', 'documentation', 'example', 'licenses', 'packaging', 'distribution', 'server', 'solr-ref-guide', 'solrj', 'solrj-streaming', 'solrj-zookeeper', 'test-framework', 'webapp', '.gitignore', '.gitattributes']
640640
is_in_list(in_root_folder, expected_src_root_folders)
641641
is_in_list(in_root_folder, expected_src_root_files)
642642
is_in_list(in_solr_folder, expected_src_solr_folders)
@@ -646,7 +646,7 @@ def verifyUnpacked(java, artifact, unpackPath, gitRevision, version, testArgs):
646646
elif isSlim:
647647
is_in_list(in_root_folder, ['bin', 'docker', 'docs', 'example', 'licenses', 'server', 'lib'])
648648
else:
649-
is_in_list(in_root_folder, ['bin', 'modules', 'cross-dc-manager', 'docker', 'prometheus-exporter', 'docs', 'example', 'licenses', 'server', 'lib'])
649+
is_in_list(in_root_folder, ['bin', 'modules', 'cross-dc-manager', 'docker', 'docs', 'example', 'licenses', 'server', 'lib'])
650650

651651
if len(in_root_folder) > 0:
652652
raise RuntimeError('solr: unexpected files/dirs in artifact %s: %s' % (artifact, in_root_folder))

gradle/libs.versions.toml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,8 @@ onnx = "1.23.0"
176176
openapi = "7.14.0"
177177
openjdk-jmh = "1.37"
178178
opentelemetry = "1.53.0"
179+
opentelemetry-prometheus = "1.50.0-alpha"
180+
opentelemetry-runtime-telemetry = "2.11.0-alpha"
179181
osgi-annotation = "8.1.0"
180182
oshai-logging = "7.0.13"
181183
# @keep for version alignment
@@ -320,11 +322,7 @@ cybozulabs-langdetect = { module = "com.cybozu.labs:langdetect", version.ref = "
320322
decompose-decompose = { module = "com.arkivanov.decompose:decompose", version.ref = "decompose" }
321323
decompose-extensions-compose = { module = "com.arkivanov.decompose:extensions-compose", version.ref = "decompose" }
322324
dropwizard-metrics-core = { module = "io.dropwizard.metrics:metrics-core", version.ref = "dropwizard-metrics" }
323-
dropwizard-metrics-graphite = { module = "io.dropwizard.metrics:metrics-graphite", version.ref = "dropwizard-metrics" }
324-
dropwizard-metrics-jetty12 = { module = "io.dropwizard.metrics:metrics-jetty12", version.ref = "dropwizard-metrics" }
325325
dropwizard-metrics-jetty12-ee10 = { module = "io.dropwizard.metrics:metrics-jetty12-ee10", version.ref = "dropwizard-metrics" }
326-
dropwizard-metrics-jmx = { module = "io.dropwizard.metrics:metrics-jmx", version.ref = "dropwizard-metrics" }
327-
dropwizard-metrics-jvm = { module = "io.dropwizard.metrics:metrics-jvm", version.ref = "dropwizard-metrics" }
328326
dropwizard-metrics-servlets = { module = "io.dropwizard.metrics:metrics-jakarta-servlets", version.ref = "dropwizard-metrics" }
329327
eclipse-jdt-ecj = { module = "org.eclipse.jdt:ecj", version.ref = "eclipse-ecj" }
330328
eclipse-jetty-alpnjavaclient = { module = "org.eclipse.jetty:jetty-alpn-java-client", version.ref = "eclipse-jetty" }
@@ -484,6 +482,9 @@ opentelemetry-api = { module = "io.opentelemetry:opentelemetry-api", version.ref
484482
opentelemetry-bom = { module = "io.opentelemetry:opentelemetry-bom", version.ref = "opentelemetry" }
485483
opentelemetry-context = { module = "io.opentelemetry:opentelemetry-context", version.ref = "opentelemetry" }
486484
opentelemetry-exporter-otlp = { module = "io.opentelemetry:opentelemetry-exporter-otlp", version.ref = "opentelemetry" }
485+
opentelemetry-exporter-prometheus = { module = "io.opentelemetry:opentelemetry-exporter-prometheus", version.ref = "opentelemetry-prometheus" }
486+
opentelemetry-exporter-sender-okhttp = { module = "io.opentelemetry:opentelemetry-exporter-sender-okhttp", version.ref = "opentelemetry" }
487+
opentelemetry-runtime-telemetry = { module = "io.opentelemetry.instrumentation:opentelemetry-runtime-telemetry-java17", version.ref = "opentelemetry-runtime-telemetry" }
487488
opentelemetry-sdk = { module = "io.opentelemetry:opentelemetry-sdk", version.ref = "opentelemetry" }
488489
opentelemetry-sdkextension-autoconfigure = { module = "io.opentelemetry:opentelemetry-sdk-extension-autoconfigure", version.ref = "opentelemetry" }
489490
opentelemetry-sdktesting = { module = "io.opentelemetry:opentelemetry-sdk-testing", version.ref = "opentelemetry" }

gradle/maven/defaults-maven.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ configure(rootProject) {
3030
":solr:solrj",
3131
":solr:solrj-streaming",
3232
":solr:solrj-zookeeper",
33-
":solr:prometheus-exporter",
3433
":solr:test-framework",
3534
] + project(":solr:modules").getChildProjects().values().path
3635

gradle/solr/packaging.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,11 @@
3636
// I don't know how to untie these two cleanly.
3737
//
3838

39-
configure(allprojects.findAll {project -> project.path.startsWith(":solr:modules:") || project.path == ":solr:prometheus-exporter" || project.path == ":solr:cross-dc-manager" }) {
39+
configure(allprojects.findAll {project -> project.path.startsWith(":solr:modules:") || project.path == ":solr:cross-dc-manager" }) {
4040
plugins.withType(JavaPlugin) {
4141
project.ext {
4242
packagingDir = file("${buildDir}/packaging")
43-
if (project.path.startsWith(":solr:prometheus-exporter") || project.path.startsWith(":solr:cross-dc-manager")) {
43+
if (project.path.startsWith(":solr:cross-dc-manager")) {
4444
deps = packagingDir
4545
} else {
4646
deps = file("${packagingDir}/${project.name}")

gradle/testing/randomization/policies/solr-tests.policy

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -130,11 +130,11 @@ grant {
130130
permission javax.management.MBeanServerPermission "findMBeanServer";
131131
permission javax.management.MBeanServerPermission "releaseMBeanServer";
132132
permission javax.management.MBeanTrustPermission "register";
133-
133+
134134
// needed by crossdc
135135
permission javax.security.auth.AuthPermission "getLoginConfiguration";
136136
permission javax.security.auth.AuthPermission "setLoginConfiguration";
137-
137+
138138
// needed by benchmark
139139
permission java.security.SecurityPermission "insertProvider";
140140

@@ -206,7 +206,7 @@ grant {
206206

207207
// additional permissions based on system properties set by /bin/solr
208208
// NOTE: if the property is not set, the permission entry is ignored.
209-
grant {
209+
grant {
210210
permission java.io.FilePermission "${solr.jetty.keystore}", "read,write,delete,readlink";
211211
permission java.io.FilePermission "${solr.jetty.keystore}${/}-", "read,write,delete,readlink";
212212

@@ -279,3 +279,7 @@ grant {
279279

280280
permission java.lang.RuntimePermission "loadLibrary.cudart";
281281
};
282+
283+
grant {
284+
permission jdk.jfr.FlightRecorderPermission "accessFlightRecorder";
285+
};

settings.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ include "solr:documentation"
6666
include "solr:packaging"
6767
include "solr:distribution"
6868
include "solr:docker"
69-
include "solr:prometheus-exporter"
7069

7170
def disableUiModuleValue = providers.gradleProperty('disableUiModule').orNull
7271
gradle.ext.withUiModule = disableUiModuleValue == null || disableUiModuleValue != 'true'

solr/README.adoc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,6 @@ Contains modules to extend the functionality of Solr.
5555
link:packaging/[]::
5656
Gradle project to build the binary release of Solr.
5757
58-
link:prometheus-exporter/[]::
59-
Contains a separate application to monitor Solr instances and export Prometheus metrics.
60-
6158
link:server/[]::
6259
Gradle project that builds the Jetty server to run Solr.
6360

0 commit comments

Comments
 (0)