SOLR-17276: Prometheus Exporter: scrape metrics at fixed rate (#2442)

rafalh · web-flow · commit 759b94fcae81 · 2024-08-03T00:53:21.000-04:00
diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
@@ -151,6 +151,8 @@ New Features
 
 * SOLR-10255: Add support for docValues to solr.BinaryField. (Alexey Serba via Mikhail Khludnev, David Smiley)
 
+* SOLR-17276: Prometheus Exporter: now scrapes metrics at a fixed rate instead of delay. (Rafał Harabień)
+
 Improvements
 ---------------------
 * SOLR-10808, SOLR-12963: The Solr schema version has been increased to 1.7.
diff --git a/solr/prometheus-exporter/src/java/org/apache/solr/prometheus/collector/SchedulerMetricsCollector.java b/solr/prometheus-exporter/src/java/org/apache/solr/prometheus/collector/SchedulerMetricsCollector.java
@@ -74,7 +74,7 @@ public SchedulerMetricsCollector(
   }
 
   public void start() {
-    scheduler.scheduleWithFixedDelay(this::collectMetrics, 0, duration, timeUnit);
+    scheduler.scheduleAtFixedRate(this::collectMetrics, 0, duration, timeUnit);
   }
 
   @SuppressWarnings("try")

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ public SchedulerMetricsCollector(`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`public void start() {`
`77`		`- scheduler.scheduleWithFixedDelay(this::collectMetrics, 0, duration, timeUnit);`
	`77`	`+ scheduler.scheduleAtFixedRate(this::collectMetrics, 0, duration, timeUnit);`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`@SuppressWarnings("try")`