SOLR-17113: fix backup response in case of exception (#2334)

stforek · Przemyslaw Ciezkowski · gerlowskija · web-flow · commit 883fd6d941c3 · 2024-03-26T22:21:36.000-04:00
---------

Co-authored-by: Przemyslaw Ciezkowski &lt;pciezkowski@box.com&gt;
Co-authored-by: Jason Gerlowski &lt;gerlowskija@apache.org&gt;
diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
@@ -152,6 +152,8 @@ Bug Fixes
 
 * SOLR-17209: Fix NullPointerException in QueryComponent (Vincent Primault via Eric Pugh)
 
+* SOLR-17113: Correct how `/replication?command=details` describes errors in backup operations.  (Przemyslaw Ciezkowski via Christine Poerschke and Jason Gerlowski)
+
 Dependency Upgrades
 ---------------------
 
diff --git a/solr/core/src/java/org/apache/solr/handler/SnapShooter.java b/solr/core/src/java/org/apache/solr/handler/SnapShooter.java
@@ -255,7 +255,7 @@ public void createSnapAsync(final int numberToKeep, Consumer<NamedList<?>> resul
                 V2ApiUtils.squashIntoNamedListWithoutHeader(snapShootDetails, createSnapshot());
               } catch (Exception e) {
                 log.error("Exception while creating snapshot", e);
-                snapShootDetails = new NamedList<>();
+                snapShootDetails = new SimpleOrderedMap<>();
                 snapShootDetails.add("exception", e.getMessage());
               }
               if (snapshotName == null) {

Original file line number	Diff line number	Diff line change
`@@ -255,7 +255,7 @@ public void createSnapAsync(final int numberToKeep, Consumer<NamedList<?>> resul`
`255`	`255`	`V2ApiUtils.squashIntoNamedListWithoutHeader(snapShootDetails, createSnapshot());`
`256`	`256`	`} catch (Exception e) {`
`257`	`257`	`log.error("Exception while creating snapshot", e);`
`258`		`- snapShootDetails = new NamedList<>();`
	`258`	`+ snapShootDetails = new SimpleOrderedMap<>();`
`259`	`259`	`snapShootDetails.add("exception", e.getMessage());`
`260`	`260`	`}`
`261`	`261`	`if (snapshotName == null) {`