Skip to content

Commit b187595

Browse files
authored
SOLR-17058: fix TestDistribIDF.testDisableDistribStats failure on LRUStatsCache (#2299)
- use another field to penetrate LRUStatsCache
1 parent 0d9a1da commit b187595

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

solr/core/src/test/org/apache/solr/search/stats/TestDistribIDF.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
import org.apache.solr.common.SolrInputDocument;
3232
import org.apache.solr.common.cloud.CompositeIdRouter;
3333
import org.apache.solr.common.cloud.ImplicitDocRouter;
34-
import org.apache.solr.common.params.CommonParams;
3534
import org.apache.solr.common.params.ShardParams;
3635
import org.apache.solr.common.util.NamedList;
3736
import org.apache.solr.embedded.JettySolrRunner;
@@ -300,20 +299,20 @@ public void testDisableDistribStats() throws Exception {
300299
assertNotNull("stats cache hit", track.get("PARSE_QUERY"));
301300

302301
// distributed stats explicitly disabled
303-
query.set(CommonParams.DISTRIB_STATS_CACHE, "false");
304-
query.set(CommonParams.Q, "{!terms f=id}1,2");
302+
query.set("distrib.statsCache", "false");
303+
query.set("q", "{!terms f=id}1,2");
305304
rsp = client.query(COLLECTION, query);
306305
track = (NamedList<Object>) rsp.getDebugMap().get("track");
307306
assertNotNull(track);
308307
assertNull("NO stats cache hit", track.get("PARSE_QUERY"));
309308
assertNotNull("just search", track.get("EXECUTE_QUERY"));
310309

311310
// distributed stats explicitly enabled
312-
query.set(CommonParams.DISTRIB_STATS_CACHE, "true");
313-
query.set(CommonParams.Q, "cat:electronics");
311+
query.set("distrib.statsCache", "true");
312+
query.set("q", "name:ipad"); // trick around LRUStatsCache
314313
rsp = client.query(COLLECTION, query);
315314
track = (NamedList<Object>) rsp.getDebugMap().get("track");
316315
assertNotNull(track);
317-
assertNotNull("stats cache hit", track.get("PARSE_QUERY"));
316+
assertNotNull("stats cache hit:" + track, track.get("PARSE_QUERY"));
318317
}
319318
}

0 commit comments

Comments
 (0)