SOLR-17503: Comple javax to Jakarta EE migration (#3839)

* smokeTestRelease needn't suppress its violation search of java/javax in JARs in certain places.
* forbidden-api; change javax.servlet->jakarta.servlet
* exclude javax.inject in tests of gcs-repository
* NOTICE.txt, remove obsolete references to servlet matters

Author: dsmiley

NOTICE.txt

@@ -255,9 +255,6 @@ LGPL and Creative Commons ShareAlike.
 Morfologic includes data from BSD-licensed dictionary of Polish (SGJP)
 (http://sgjp.pl/morfeusz/)
 
-Servlet-api.jar and javax.servlet-*.jar are under the CDDL license, the original
-source code for this can be found at http://www.eclipse.org/jetty/downloads.php
-
 ===========================================================================
 Kuromoji Japanese Morphological Analyzer - Apache Lucene Integration
 ===========================================================================
@@ -377,9 +374,6 @@ This product includes software developed by the Eclipse Foundation
 (specifically, Jetty, the bundled servlet container in example),
 available under the Apache 2 License.
 
-Servlet-api.jar is under the CDDL license, the original source
-code for this can be found at http://www.eclipse.org/jetty/downloads.php
-
 =========================================================================
 ==  SLF4J Notice -- http://www.slf4j.org/license.html                  ==
 =========================================================================

changelog/unreleased/SOLR-17503-noJavax.yml

@@ -0,0 +1,10 @@
+# See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc
+title: Completed javax to Jakarta EE transition
+type: other # added, changed, fixed, deprecated, removed, dependency_update, security, other
+authors:
+  - name: David Smiley
+links:
+  - name: SOLR-17503
+    url: https://issues.apache.org/jira/browse/SOLR-17503
+  - name: SOLR-17069
+    url: https://issues.apache.org/jira/browse/SOLR-17069

dev-tools/scripts/smokeTestRelease.py

@@ -209,12 +209,6 @@ def checkAllJARs(topDir, gitRevision, version):
 
     for file in files:
       if file.lower().endswith('.jar'):
-        if ((normRoot.endswith('/modules/extraction/lib') and (file.startswith('jakarta.activation-') or file.startswith('jakarta.xml')))
-            or (normRoot.endswith('/modules/extraction/lib') and file.startswith('unit-api-'))
-            or (normRoot.endswith('/server/solr-webapp/webapp/WEB-INF/lib') and file.startswith('jakarta.'))
-            or (normRoot.endswith('/server/lib/ext') and file.startswith('jetty-servlet-api-'))):
-          print('      **WARNING**: skipping check of %s/%s: it has javax.* classes' % (root, file))
-          continue
         fullPath = '%s/%s' % (root, file)
         noJavaPackageClasses('JAR file "%s"' % fullPath, fullPath)
         if file.lower().find('solr') != -1:

gradle/validation/forbidden-apis/javax.servlet.javax.servlet-api.solr.txt renamed to gradle/validation/forbidden-apis/jakarta.servlet.jakarta.servlet-api.all.txt

@@ -15,17 +15,17 @@
 
 @defaultMessage Servlet API method is parsing request parameters without using the correct encoding if no extra configuration is given in the servlet container
 
-javax.servlet.ServletRequest#getParameter(**) 
-javax.servlet.ServletRequest#getParameterMap(**) 
-javax.servlet.ServletRequest#getParameterNames(**) 
-javax.servlet.ServletRequest#getParameterValues(**) 
+jakarta.servlet.ServletRequest#getParameter(**)
+jakarta.servlet.ServletRequest#getParameterMap(**)
+jakarta.servlet.ServletRequest#getParameterNames(**)
+jakarta.servlet.ServletRequest#getParameterValues(**)
 
-javax.servlet.http.HttpServletRequest#getSession() @ Servlet API getter has side effect of creating sessions
+jakarta.servlet.http.HttpServletRequest#getSession() @ Servlet API getter has side effect of creating sessions
 
 @defaultMessage Servlet API method is broken and slow in some environments (e.g., Jetty's UTF-8 readers)
 
-javax.servlet.ServletRequest#getReader()
-javax.servlet.ServletResponse#getWriter()
-javax.servlet.ServletInputStream#readLine(**) 
-javax.servlet.ServletOutputStream#print(**)
-javax.servlet.ServletOutputStream#println(**)
+jakarta.servlet.ServletRequest#getReader()
+jakarta.servlet.ServletResponse#getWriter()
+jakarta.servlet.ServletInputStream#readLine(**)
+jakarta.servlet.ServletOutputStream#print(**)
+jakarta.servlet.ServletOutputStream#println(**)