Skip to content

Commit c30e2d0

Browse files
malliaridisepugh
andauthored
SOLR-16996: Update Solr Exporter for Prometheus cli to use commons-cli (#2602)
* Migrate SolrExporter to use commons-cli and remove argparse4j * now trigger bats testing when anything changes in the exporter code base to provide better testing --------- Co-authored-by: Eric Pugh <[email protected]>
1 parent 88fa620 commit c30e2d0

File tree

5 files changed

+178
-168
lines changed

5 files changed

+178
-168
lines changed

.github/workflows/bin-solr-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ on:
1010
- 'solr/bin/**'
1111
- 'solr/packaging/**'
1212
- 'solr/core/src/java/org/apache/solr/cli/**'
13+
- 'solr/prometheus-exporter/**'
1314

1415
jobs:
1516
test:
@@ -47,4 +48,3 @@ jobs:
4748
with:
4849
name: logs
4950
path: solr/packaging/build/test-output
50-

solr/prometheus-exporter/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ dependencies {
4343
exclude group: "com.fasterxml.jackson.core", module: "jackson-databind"
4444
})
4545
implementation ('com.fasterxml.jackson.core:jackson-databind')
46-
implementation ('net.sourceforge.argparse4j:argparse4j')
46+
implementation 'commons-cli:commons-cli'
4747
implementation ('com.github.ben-manes.caffeine:caffeine') { transitive = false }
4848
implementation 'org.slf4j:slf4j-api'
4949
implementation 'commons-codec:commons-codec'

0 commit comments

Comments
 (0)