SOLR-17471: upgrade Lucene to version 9.12.1 (#2736)

Author: psalagnac

dev-docs/lucene-upgrade.md

@@ -27,7 +27,7 @@ Create a new branch locally e.g. `git checkout -b lucene940 -t origin/main` for
 
 ## Build
 
-### `versions.props` update
+### `gradle/libs.versions.toml` update
 
 ```
 - org.apache.lucene:*=9.3.0
@@ -37,7 +37,7 @@ Create a new branch locally e.g. `git checkout -b lucene940 -t origin/main` for
 ### `versions.lock` update
 
 ```
-gradlew --write-locks
+gradlew :writeLocks
 ```
 
 ### `solr/licenses` update

gradle/libs.versions.toml

@@ -39,7 +39,7 @@ apache-httpcomponents-httpcore = "4.4.16"
 apache-httpcomponents-httpmime = "4.5.14"
 apache-kafka = "3.7.1"
 apache-log4j = "2.21.0"
-apache-lucene = "9.11.1"
+apache-lucene = "9.12.1"
 apache-opennlp = "1.9.4"
 apache-poi = "5.2.2"
 apache-rat = "0.15"

solr/CHANGES.txt

@@ -170,7 +170,7 @@ Bug Fixes
 
 Dependency Upgrades
 ---------------------
-(No changes)
+* SOLR-17471: Upgrade Lucene to 9.12.1. (Pierre Salagnac, Christine Poerschke)
 
 Other Changes
 ---------------------

solr/core/src/java/org/apache/solr/core/SchemaCodecFactory.java

@@ -26,8 +26,8 @@
 import org.apache.lucene.codecs.KnnVectorsReader;
 import org.apache.lucene.codecs.KnnVectorsWriter;
 import org.apache.lucene.codecs.PostingsFormat;
-import org.apache.lucene.codecs.lucene99.Lucene99Codec;
-import org.apache.lucene.codecs.lucene99.Lucene99Codec.Mode;
+import org.apache.lucene.codecs.lucene912.Lucene912Codec;
+import org.apache.lucene.codecs.lucene912.Lucene912Codec.Mode;
 import org.apache.lucene.codecs.lucene99.Lucene99HnswVectorsFormat;
 import org.apache.lucene.index.SegmentReadState;
 import org.apache.lucene.index.SegmentWriteState;
@@ -97,7 +97,7 @@ public void init(NamedList<?> args) {
       log.debug("Using default compressionMode: {}", compressionMode);
     }
     codec =
-        new Lucene99Codec(compressionMode) {
+        new Lucene912Codec(compressionMode) {
           @Override
           public PostingsFormat getPostingsFormatForField(String field) {
             final SchemaField schemaField = core.getLatestSchema().getFieldOrNull(field);

solr/core/src/java/org/apache/solr/core/backup/repository/BackupRepository.java

@@ -31,7 +31,6 @@
 import org.apache.lucene.store.IndexOutput;
 import org.apache.lucene.util.IOUtils;
 import org.apache.solr.common.params.CoreAdminParams;
-import org.apache.solr.core.DirectoryFactory;
 import org.apache.solr.core.backup.Checksum;
 import org.apache.solr.util.plugin.NamedListInitializedPlugin;
 
@@ -217,9 +216,8 @@ default void copyIndexFileFrom(
       Directory sourceDir, String sourceFileName, Directory destDir, String destFileName)
       throws IOException {
     boolean success = false;
-    try (ChecksumIndexInput is =
-            sourceDir.openChecksumInput(sourceFileName, DirectoryFactory.IOCONTEXT_NO_CACHE);
-        IndexOutput os = destDir.createOutput(destFileName, DirectoryFactory.IOCONTEXT_NO_CACHE)) {
+    try (ChecksumIndexInput is = sourceDir.openChecksumInput(sourceFileName, IOContext.READONCE);
+        IndexOutput os = destDir.createOutput(destFileName, IOContext.READONCE)) {
       os.copyBytes(is, is.length() - CodecUtil.footerLength());
 
       // ensure that index file is not corrupted
@@ -300,8 +298,8 @@ default void copyFileNoChecksum(
       Directory sourceDir, String sourceFileName, Directory destDir, String destFileName)
       throws IOException {
     boolean success = false;
-    try (IndexInput is = sourceDir.openInput(sourceFileName, DirectoryFactory.IOCONTEXT_NO_CACHE);
-        IndexOutput os = destDir.createOutput(destFileName, DirectoryFactory.IOCONTEXT_NO_CACHE)) {
+    try (IndexInput is = sourceDir.openInput(sourceFileName, IOContext.READONCE);
+        IndexOutput os = destDir.createOutput(destFileName, IOContext.READONCE)) {
       os.copyBytes(is, is.length());
       success = true;
     } finally {

solr/core/src/java/org/apache/solr/search/similarities/ClassicSimilarityFactory.java

@@ -31,7 +31,7 @@
  * <p>Optional settings:
  *
  * <ul>
- *   <li>discountOverlaps (bool): Sets {@link ClassicSimilarity#setDiscountOverlaps(boolean)}
+ *   <li>discountOverlaps (bool): Sets {@link ClassicSimilarity#getDiscountOverlaps()}.
  * </ul>
  *
  * @see TFIDFSimilarity
@@ -41,13 +41,13 @@ public class ClassicSimilarityFactory extends SimilarityFactory {
 
   /**
    * Init param name for specifying the value to use in {@link
-   * ClassicSimilarity#setDiscountOverlaps(boolean)}
+   * ClassicSimilarity#getDiscountOverlaps()}.
    */
   public static final String DISCOUNT_OVERLAPS = "discountOverlaps";
 
   /**
-   * Controls the value of {@link ClassicSimilarity#setDiscountOverlaps(boolean)} on newly
-   * constructed instances of {@link ClassicSimilarity}
+   * Controls the value of {@link ClassicSimilarity#getDiscountOverlaps()} on newly constructed
+   * instances of {@link ClassicSimilarity}
    */
   protected boolean discountOverlaps = true;
 
@@ -59,8 +59,6 @@ public void init(SolrParams params) {
 
   @Override
   public Similarity getSimilarity() {
-    ClassicSimilarity sim = new ClassicSimilarity();
-    sim.setDiscountOverlaps(discountOverlaps);
-    return sim;
+    return new ClassicSimilarity(discountOverlaps);
   }
 }

solr/core/src/java/org/apache/solr/search/similarities/DFISimilarityFactory.java

@@ -39,8 +39,7 @@
  * Optional settings:
  *
  * <ul>
- *   <li>discountOverlaps (bool): Sets {@link
- *       org.apache.lucene.search.similarities.SimilarityBase#setDiscountOverlaps(boolean)}
+ *   <li>discountOverlaps (bool): Sets {link Similarity#getDiscountOverlaps()}
  * </ul>
  *
  * @lucene.experimental
@@ -59,9 +58,7 @@ public void init(SolrParams params) {
 
   @Override
   public Similarity getSimilarity() {
-    DFISimilarity sim = new DFISimilarity(independenceMeasure);
-    sim.setDiscountOverlaps(discountOverlaps);
-    return sim;
+    return new DFISimilarity(independenceMeasure, discountOverlaps);
   }
 
   private Independence parseIndependenceMeasure(String expr) {

solr/core/src/java/org/apache/solr/search/similarities/DFRSimilarityFactory.java

@@ -86,7 +86,7 @@
  * <p>Optional settings:
  *
  * <ul>
- *   <li>discountOverlaps (bool): Sets {@link DFRSimilarity#setDiscountOverlaps(boolean)}
+ *   <li>discountOverlaps (bool): Sets {@link Similarity#getDiscountOverlaps()}
  * </ul>
  *
  * @lucene.experimental
@@ -160,8 +160,6 @@ static Normalization parseNormalization(String expr, String c, String mu, String
 
   @Override
   public Similarity getSimilarity() {
-    DFRSimilarity sim = new DFRSimilarity(basicModel, afterEffect, normalization);
-    sim.setDiscountOverlaps(discountOverlaps);
-    return sim;
+    return new DFRSimilarity(basicModel, afterEffect, normalization, discountOverlaps);
   }
 }

solr/core/src/java/org/apache/solr/search/similarities/IBSimilarityFactory.java

@@ -56,7 +56,7 @@
  * <p>Optional settings:
  *
  * <ul>
- *   <li>discountOverlaps (bool): Sets {@link IBSimilarity#setDiscountOverlaps(boolean)}
+ *   <li>discountOverlaps (bool): Sets {link Similarity#getDiscountOverlaps()}
  * </ul>
  *
  * @lucene.experimental
@@ -100,8 +100,6 @@ private Lambda parseLambda(String expr) {
 
   @Override
   public Similarity getSimilarity() {
-    IBSimilarity sim = new IBSimilarity(distribution, lambda, normalization);
-    sim.setDiscountOverlaps(discountOverlaps);
-    return sim;
+    return new IBSimilarity(distribution, lambda, normalization, discountOverlaps);
   }
 }

solr/core/src/java/org/apache/solr/search/similarities/LMDirichletSimilarityFactory.java

@@ -17,6 +17,7 @@
 package org.apache.solr.search.similarities;
 
 import org.apache.lucene.search.similarities.LMDirichletSimilarity;
+import org.apache.lucene.search.similarities.LMSimilarity;
 import org.apache.lucene.search.similarities.Similarity;
 import org.apache.solr.common.params.SolrParams;
 import org.apache.solr.schema.SimilarityFactory;
@@ -33,7 +34,7 @@
  * <p>Optional settings:
  *
  * <ul>
- *   <li>discountOverlaps (bool): Sets {@link LMDirichletSimilarity#setDiscountOverlaps(boolean)}
+ *   <li>discountOverlaps (bool): Sets {link Similarity#getDiscountOverlaps()}
  * </ul>
  *
  * @lucene.experimental
@@ -51,9 +52,13 @@ public void init(SolrParams params) {
 
   @Override
   public Similarity getSimilarity() {
-    LMDirichletSimilarity sim =
-        (mu != null) ? new LMDirichletSimilarity(mu) : new LMDirichletSimilarity();
-    sim.setDiscountOverlaps(discountOverlaps);
-    return sim;
+
+    // Default μ is 2000 in Lucene. Unfortunately, there is no constant we can use
+    if (mu == null) {
+      mu = 2000f;
+    }
+
+    LMSimilarity.CollectionModel model = new LMSimilarity.DefaultCollectionModel();
+    return new LMDirichletSimilarity(model, discountOverlaps, mu);
   }
 }