SOLR-17955: OTEL metrics: SplitShardCmd.checkDiskSpace needs conversion #3859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlbiscoc
commented
Nov 12, 2025
Comment on lines
+901
to
909
| if (indexSize == -1.0) { | ||
| log.warn("cannot verify information for parent shard leader"); | ||
| return; | ||
| } | ||
| double indexSize = size.doubleValue(); | ||
|
|
||
| Number freeSize = | ||
| (Number) rsp.getResponse()._get(List.of("metrics", freeDiskSpaceMetricName), null); | ||
| if (freeSize == null) { | ||
| if (freeSize == -1.0) { | ||
| log.warn("missing node disk space information for parent shard leader"); | ||
| return; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I'm thinking for here, this should throw instead of just return and continuing with the shard split cmd. Tests were passing because of this. Then we could at least know there was a regression. Was this just return for some specific purpose?
Contributor
There was a problem hiding this comment.
At least assert but I'm +1 to just throw if you wish.
dsmiley
reviewed
Nov 14, 2025
|
|
||
| SolrResponse resp = req.process(cloudManager.getSolrClient()); | ||
|
|
||
| double[] sizes = new double[] {-1.0, -1.0}; // [indexSize, freeSize] |
Comment on lines
+901
to
909
| if (indexSize == -1.0) { | ||
| log.warn("cannot verify information for parent shard leader"); | ||
| return; | ||
| } | ||
| double indexSize = size.doubleValue(); | ||
|
|
||
| Number freeSize = | ||
| (Number) rsp.getResponse()._get(List.of("metrics", freeDiskSpaceMetricName), null); | ||
| if (freeSize == null) { | ||
| if (freeSize == -1.0) { | ||
| log.warn("missing node disk space information for parent shard leader"); | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
At least assert but I'm +1 to just throw if you wish.
| SolrRequest.METHOD.GET, "/admin/metrics", SolrRequest.SolrRequestType.ADMIN, params); | ||
| req.setResponseParser(new InputStreamResponseParser("prometheus")); | ||
|
|
||
| SolrResponse resp = req.process(cloudManager.getSolrClient()); |
Contributor
There was a problem hiding this comment.
this is going to talk to some arbitrary node, not necessarily the node that has the specific core we are going to split. To do that, you can get the URL from the Replica, truncate to the node, and use Http2SolrClient.requestWithBaseUrl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17955
Splitshard disk space check was broken when switching the /admin/metrics api to prometheus. This fixes that by reading the parsed prometheus output.